AIP-84 Migrate Clear Dag Run public endpoint to FastAPI

[rawwar]

related to #42701

[rawwar]

@pierrejeambrun , I noticed that in legacy implementation, for clear dag run endpoint with dry_run=True, the response is supposed to be a TaskInstanceCollection. However, the response only includes few attributes of TI. Below is an example response :

{
"task_instances": [
{
"dag_id": "example_astronauts",
"dag_run_id": "manual__2024-11-03T14:05:08.832062+00:00",
"execution_date": "2024-11-03T14:05:08.832062+00:00",
"task_id": "print_astronaut_craft"
},{
"dag_id": "example_astronauts",
"dag_run_id": "manual__2024-11-03T14:05:08.832062+00:00",
"execution_date": "2024-11-03T14:05:08.832062+00:00",
"task_id": "get_astronauts"
}

Related schema: TaskInstanceReferenceSchema
Should I keep the same? Or should I return all the details?

I tried to return all details. But, to do that, it seems I can't reuse the methods in the legacy implementation as it is causing the following error.

Error extracting attribute: DetachedInstanceError: Parent instance <TaskInstance at 0x31af2e880> is not bound to a Session; lazy load operation of attribute 'task_instance_note' cannot proceed (Background on this error at: https://sqlalche.me/e/14/bhk3) [type=get_attribute_error, input_value=<TaskInstance: example_as....832062+00:00 [success]>, input_type=TaskInstance]

I guess, I just need to use joinload. But, thinking if I should update here or just rewrite a select query within clear_dag_run method

[pierrejeambrun]

I think we can do the same and return a partial response. There is a way to do that in fastapi specifying the response model. And we need to document it in the swagger with example responses.

DetachedInstance error is most certainly due to a bad session handling. (session used to fetch objects is closed too early or something similar)

[rawwar]

I think we can do the same and return a partial response. There is a way to do that in fastapi specifying the response model. And we need to document it in the swagger with example responses.

I went with returning the entire object. Is that fine? If not, I can return the partial response. I already looked into how to do it

[pierrejeambrun]

Nice!

A few suggestions/questions

[pierrejeambrun]

Nice, a few minor suggestions and ready to merge, thanks