Fix instruction for docker compose(tested on Mac M1) - #43119

Merged
shahar1 merged 4 commits into
apache:mainfrom
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged

Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom
Udbv:docs/fix_docker_compose_how_to

Conversation

@Udbv

@UdbvUdbv commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

Make fixes that allows to run airflow dags in pycharm debugger on Mac M1

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Udbv
Udbv requested a review from potiuk as a code ownerOctober 17, 2024 13:53
@boring-cyborg

boring-cyborgBot commented Oct 17, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

shahar1
shahar1 approved these changes Oct 17, 2024
View reviewed changes

@shahar1shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!
I ran a small fix for static checks.

@Udbv

Udbv commented Oct 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks, @potiuk@shahar1 Seems like I fixed linter issue

Udbvand others added 3 commits October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed the docs/fix_docker_compose_how_to branch from c3f70fb to 9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1 added this to the Airflow 2.10.3 milestone Oct 23, 2024
@shahar1
shahar1 merged commit d725cf6 into apache:mainOct 23, 2024
@boring-cyborg

boring-cyborgBot commented Oct 23, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

shahar1 added a commit to shahar1/airflow that referenced this pull request Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1 mentioned this pull request Oct 23, 2024
Merged
kaxil pushed a commit that referenced this pull request Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2 added the type:doc-only Changelog: Doc Only label Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees

No one assigned

Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects

None yet

Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix instruction for docker compose(tested on Mac M1) - #43119
Merged
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Oct 23, 2024
Merged
Fix instruction for docker compose(tested on Mac M1)#43119
shahar1 merged 4 commits into
apache:mainfrom 
Udbv:docs/fix_docker_compose_how_to
Conversation
@Udbv
@UdbvUdbv
commented
Oct 17, 2024

Copy link


Copy Markdown

Contributor
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.
@Udbv
Udbv
requested a review
from potiuk
as a code ownerOctober 17, 2024 13:53
@boring-cyborg
boring-cyborgBot
commented
Oct 17, 2024

Copy link


Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)

Here are some useful points:
  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    
Apache Airflow is a community-driven project and together we are making it better 🚀.
    
In case of doubts contact the developers at:
    
Mailing List: dev@airflow.apache.org
    
Slack: https://s.apache.org/airflow-slack
shahar1
shahar1
approved these changes
Oct 17, 2024
View reviewed changes
@shahar1shahar1
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Airflow and thanks for your contribution!

I ran a small fix for static checks.
@Udbv
Udbv
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks, @potiuk@shahar1 Seems like I fixed linter issue
Udbvand others
added 3 commits
October 23, 2024 16:56
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1)
2bc942d
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
@shahar1
fix static checks
477a640
@Udbv@shahar1
fix linter error
9f1bf9d
@shahar1
shahar1force-pushed
the
docs/fix_docker_compose_how_to
branch
from
c3f70fb to
9f1bf9dCompareOctober 23, 2024 14:20
@shahar1shahar1
added this to the Airflow 2.10.3 milestone
Oct 23, 2024
@shahar1
shahar1
merged commit d725cf6
into
apache:mainOct 23, 2024
@boring-cyborg
boring-cyborgBot
commented
Oct 23, 2024

Copy link


Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.
shahar1 added a commit
to shahar1/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
475f799
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
@shahar1shahar1
mentioned this pull request
Oct 23, 2024
 Merged

kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
@shahar1@Udbv
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
8e198ad
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
@Udbv@shahar1@harjeevanmaan
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
89ad57f
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
@Udbv@shahar1@PaulKobow7536
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
9b8e929
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@utkarsharma2utkarsharma2
added
the 
type:doc-only
Changelog: Doc Only
label
Oct 24, 2024
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
@shahar1@Udbv@utkarsharma2
Fix instruction for docker compose(tested on Mac M1) (#43119) (#43321)
1eadd75
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit d725cf6)
Co-authored-by: Bohdan Udovenko <bohdan.udov@gmail.com>
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
@Udbv@shahar1@ellisms
Fix instruction for docker compose(tested on Mac M1) (apache#43119)
b6fbcee
* Fix instruction for docker compose(tested on Mac M1)
Make fixes that allows to run airflow dags in pycharm debugger on Mac M1
* fix static checks
* fix linter error
* fix unexpected identation
---------
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@shahar1shahar1shahar1 approved these changes

Assignees


No one assigned


Labels

kind:documentationtype:doc-onlyChangelog: Doc Only

Projects


None yet


Milestone

Airflow 2.10.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Udbv@potiuk@shahar1@utkarsharma2