Uh oh!
There was an error while loading. Please reload this page.
Upgrade FAB to 4.5.1 - #43251
Merged
Merged
Conversation
potiuk
requested review from
ashb, bbovenzi, jscheffl, pierrejeambrun and ryanahamilton
as code ownersOctober 22, 2024 08:02
pierrejeambrun
approved these changes
Oct 22, 2024
potiukforce-pushed
the
upgrade-to-fab-4.5.1
branch
from
October 22, 2024 09:41
1996e78 to
f1e91e1Comparejedcunningham
approved these changes
Oct 22, 2024
potiuk
commented
Oct 22, 2024
MemberAuthor
OK. I know why it failed - seems like old change of mine (adding constraints) did not take into account that sometimes constraints might be conflicting with local deps (like in this case where we pin FAB). Fix in #43276 |
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
potiukforce-pushed
the
upgrade-to-fab-4.5.1
branch
from
October 23, 2024 07:59
f1e91e1 to
0a3bc99Comparepotiuk
commented
Oct 23, 2024
MemberAuthor
Merging it - there is an openlineage mypy issue that will be addressed separately. |
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
potiuk added a commit
to potiuk/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
kaxil pushed a commit
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
harjeevanmaan pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
PaulKobow7536 pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
utkarsharma2 pushed a commit
that referenced
this pull request
Oct 24, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1. (cherry picked from commit 84ff10b)
This was referenced Oct 27, 2024
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAB 4.5.1 has been released in September with a few small fixes. This change updates fab to 4.5.1 including changing the rate limiter creation that is vendored in. It has been changed in dpgaspar/Flask-AppBuilder#2254 and relased in 4.5.1. That's the only dfference in security manager between 4.5.0 and 4.5.1.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.