Uh oh!
There was an error while loading. Please reload this page.
AIP-84 Migrate post a connection to FastAPI API - #43396
Conversation
Uh oh!
There was an error while loading. Please reload this page.
jscheffl
left a comment
There was a problem hiding this comment.
One nit, else looks good.
c6c4784 to
df9b0b4CompareThere was a problem hiding this comment.
Should we handle the password as well ? How do we plan to set the connection password through the rest api ?
(And check that in the response of the POST it is properly redacted).
ATM this is done trough FAB in the Adming/Connection form that allow the password field. But this will be removed in airflow 3.0 so we should handle it in the rest API. Also the doc states passwordhttps://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html#operation/post_connection but it was not handled I believe.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Just to not merge by mistake until we clarify the password thing.
bugraoz93
commented
Oct 28, 2024
Yes, we should. Indeed, the post and the patch include a password. Awesome one! |
df9b0b4 to
ffe3dbfCompareUh oh!
There was an error while loading. Please reload this page.
b3c1864 to
827a1f2CompareThis still needs some work. I am looking |
Uh oh!
There was an error while loading. Please reload this page.
pierrejeambrun
commented
Nov 4, 2024
We need to rebase to solve conflicts, but ready to merge IMO. |
9717f7a to
5630215Comparebugraoz93
commented
Nov 4, 2024
Good to hear that! Rebased and included the field into redact from the other PR comment :) |
bugraoz93
commented
Nov 4, 2024
Something is off with the tests. These should have been caught by the CI/CD already. |
5630215 to
5d50c7eCompare* Migrate Create a Connection to FastAPI * Remove additional duplicate comment * Include password in connection and move dashboard.py to serializers/ui/ * Fix test for password * Include password field to response and redact it, run pre-commit after rebase * Convert redact to field_validator and fix tests * Pass field name into redact * run pre-commit after rebase
closes: #42593
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.