Uh oh!
There was an error while loading. Please reload this page.
AIP-65: Update dag source endpoint to support versioning - #43492
Merged
Conversation
ephraimbuddyforce-pushed
the
version-api
branch
2 times, most recently
from
October 30, 2024 06:21
bb2a352 to
3ec23a2Compareephraimbuddyforce-pushed
the
version-api
branch
from
November 7, 2024 22:40
3ec23a2 to
c157489Compareephraimbuddy
marked this pull request as ready for review
November 7, 2024 22:42
ephraimbuddy
requested review from
XD-DENG, ashb, bbovenzi, jscheffl, pierrejeambrun and ryanahamilton
as code ownersNovember 7, 2024 22:42
ephraimbuddyforce-pushed
the
version-api
branch
from
November 7, 2024 22:43
c157489 to
8fce1aaCompareephraimbuddy
commented
Nov 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
ephraimbuddyforce-pushed
the
version-api
branch
2 times, most recently
from
November 13, 2024 05:50
a541914 to
ef8cce6Compare1 task
ephraimbuddyforce-pushed
the
version-api
branch
2 times, most recently
from
November 14, 2024 08:02
611f8df to
9a2705bCompareephraimbuddyforce-pushed
the
version-api
branch
from
November 14, 2024 08:03
9a2705b to
41107bcCompareLee-W
reviewed
Nov 15, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ephraimbuddyforce-pushed
the
version-api
branch
2 times, most recently
from
November 18, 2024 12:13
de6d1c0 to
32d6edcComparejedcunningham
approved these changes
Nov 18, 2024
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Just one comment, otherwise looking good.
Uh oh!
There was an error while loading. Please reload this page.
Lee-W
approved these changes
Nov 19, 2024
Enhanced the DAG source endpoint to support version-based retrieval Refactored the get_dag_source function to allow fetching specific versions of DAG source code using dag_id, version_name, and version_number parameters. Replaced file_token with dag_id in endpoint paths and removed unnecessary token-based access. Updated OpenAPI specifications and requested serializers to include new versioning parameters. Modified API response schema to include dag_id, version_name, and version_number for improved version tracking. Added/updated tests
ephraimbuddyforce-pushed
the
version-api
branch
from
November 19, 2024 09:49
32d6edc to
d55bb36Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the DAG source endpoint to support version-based retrieval
Refactored the get_dag_source function to allow fetching specific versions of DAG source code using dag_id, version_name, and version_number parameters.
Replaced file_token with dag_id in endpoint paths and removed unnecessary token-based access.
Updated OpenAPI specifications and requested serializers to include new versioning parameters.
Modified API response schema to include dag_id, and version_number for improved version tracking.
Added/updated tests