Uh oh!
There was an error while loading. Please reload this page.
AIP-84 Migrate GET Dag Runs endpoint to FastAPI - #43506
Merged
Merged
Conversation
12 tasks
rawwar
commented
Nov 9, 2024
Uh oh!
There was an error while loading. Please reload this page.
rawwarforce-pushed
the
kalyan/AIP-84/list_dag_runs
branch
from
November 16, 2024 07:20
d893747 to
05aa18eCompareContributorAuthor
@pierrejeambrun , as of now get dag runs does not raise 404 not found if dag id is invalid. Link. Should we update it? |
2 tasks
Member
I think we should update it in the new FastAPI endpoint, I wouldn't bother fixing the legacy one though (it's not really a bug, more of an imprecision I would say, we can live with that in airflow 2.x). We can do the same as in """Get tasks for DAG."""dag: DAG=request.app.state.dag_bag.get_dag(dag_id)
ifnotdag:
raiseHTTPException(status.HTTP_404_NOT_FOUND, f"Dag with id {dag_id} was not found") |
…AIP-84/list_dag_runs
…AIP-84/list_dag_runs
rawwar
marked this pull request as ready for review
November 18, 2024 19:09
rawwar
requested review from
bbovenzi, ephraimbuddy, jscheffl and ryanahamilton
as code ownersNovember 18, 2024 19:09
rawwar
commented
Nov 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
rawwar
commented
Nov 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
…AIP-84/list_dag_runs
pierrejeambrun
approved these changes
Nov 20, 2024
pierrejeambrunforce-pushed
the
kalyan/AIP-84/list_dag_runs
branch
from
November 20, 2024 16:46
c2da15e to
273a6d7Comparegot686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* add list_dag_runs * use logical_date * add tests * wip - writing tests * add tests * fix tests * Update airflow/api_fastapi/core_api/routes/public/dag_run.py * add status * Small tweak --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #42701