Uh oh!
There was an error while loading. Please reload this page.
Make Breeze installation and reinstallation support both uv and pipx - #43607
Conversation
We'll have to cherry-pick that one to v2-10-test to enable automated breeze switching between checked out |
edd26a4 to
bbaadaaComparebbaadaa to
9e7ba7dComparepotiuk
commented
Nov 2, 2024
I also tested a few scenarios where we were switching between "breeze static checks" and "git commit" pre-commit as I noticed that they could be using different pre-commit installation, and they could make no use of the "pre-commit-uv" - I fixed it in this PR, and now also users will get warning if their pre-commit is installed without |
e19ce83 to
53ef8edCompare
amoghrajesh
left a comment
There was a problem hiding this comment.
Few nits, otherwise LGTM +1
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
7426af9 to
77a89e7CompareSo far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it.
77a89e7 to
8a96e93Compare…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…43607) (#43626) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
…pache#43607) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it.
…43607) (#43626) So far `breeze` fully supported only `pipx` installation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx. With this PR: * the `uv tool` is preferred way to install breeze * the `pipx` is PSF-governance managed alternative * breeze will reinstall itself using uv if it has been installed with uv before when it is run from a different workspace or different airflow repo checked out in another folder Also documentation is updated to make `uv` the recommended tool and describing how to install it - with `pipx` provided as an alternative. Warning is printed in case pre-commit-uv is not installed with the pre-commit (pre-commit-uv significantly speeds up installation of the venvs by pre-commit). This warning also provides instructions how to install it. (cherry picked from commit ddc5670)
So far
breezefully supported onlypipxinstallation. For example it would reinstall itself automatically with pipx if you attempted to run it from another workspace/checked out repository of Airflow, and it only provided instructions for pipx.With this PR:
uv toolis preferred way to install breezepipxis PSF-governance managed alternativeAlso documentation is updated to make
uvthe recommended tool and describing how to install it - withpipxprovided as an alternative.Warning is printed in case pre-commit-uv is not installed with the
pre-commit (pre-commit-uv significantly speeds up installation of
the venvs by pre-commit). This warning also provides instructions
how to install it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.