Uh oh!
There was an error while loading. Please reload this page.
Log message source details are grouped - #43681
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the fix, looks good for me - also valid to back-port to 2.10 line in my view.
@bbovenzi would it be okay to back-port also for you?
We had a couple of complaints from users who had (1) error markers in logs in UI even marked in red just because the celery worker was not delivering the logs internally - but logs were loaded from file successfully and (2) if logs were archived on blob storage the internal blob storage URL was posted which actually is not accessible for users.
So the first lines posted in the logs mainly confused and were not helpful... Donat came to the proposal to hide/log group them per default.
majorosdonat
commented
Nov 5, 2024
Moved back to draft until pytests are fixed |
bbovenzi
commented
Nov 5, 2024
Makes sense to me! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 9d18772)
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <mjd2bp@bosch.com>
* Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <mjd2bp@bosch.com>
* Log message source details are grouped (#43681) * Log message source details are grouped * fix static checks * fix pytests * Another pytest fix --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 9d18772) * Fix pytest --------- Co-authored-by: majorosdonat <mjd2bp@bosch.com>
Log message source details are grouped: they are not relevant for most users and can distract them from finding the root cause of their errors.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.