Skip to content

Migrate public endpoint Get Task to FastAPI - #43718

Merged
pierrejeambrun merged 3 commits into
apache:mainfrom
omkar-foss:aip-84/tasks/get-task
Nov 13, 2024
Merged

Migrate public endpoint Get Task to FastAPI#43718
pierrejeambrun merged 3 commits into
apache:mainfrom
omkar-foss:aip-84/tasks/get-task

Conversation

@omkar-foss

Copy link
Copy Markdown
Collaborator

closes: #42874
related: #42370

This migrates the Get Task API from api_connexion to api_fastapi.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 5, 2024
@omkar-fossomkar-foss added the legacy api Whether legacy API changes should be allowed in PR label Nov 5, 2024
@omkar-fossomkar-foss self-assigned this Nov 5, 2024
Comment threadairflow/api_fastapi/core_api/routes/public/tasks.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/tasks.py Outdated
Comment threadairflow/api_fastapi/core_api/serializers/tasks.py Outdated
Comment threadairflow/api_fastapi/core_api/serializers/tasks.py Outdated
Comment threadairflow/api_fastapi/core_api/serializers/tasks.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/tasks.py
@omkar-foss
omkar-fossforce-pushed the aip-84/tasks/get-task branch 2 times, most recently from 7467a22 to f0f1850CompareNovember 8, 2024 13:50
@omkar-foss

omkar-foss commented Nov 8, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@pierrejeambrun PR rebased and synced with main and all comments resolved, please check it out. Thank you!

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Need rebasing and conflicts resolution. Thanks

Comment threadairflow/api_fastapi/common/types.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_tasks.py Outdated
@omkar-foss

Copy link
Copy Markdown
CollaboratorAuthor

Overall looking good. Need rebasing and conflicts resolution. Thanks

Done! Rebased and conflicts resolved ✅

@omkar-foss
omkar-fossforce-pushed the aip-84/tasks/get-task branch 2 times, most recently from bc1d210 to eecc938CompareNovember 11, 2024 17:52

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing again. Ready to merge

@omkar-foss

omkar-foss commented Nov 13, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Needs rebasing again. Ready to merge

@pierrejeambrun rebasing done, thank you ✅

@pierrejeambrun
pierrejeambrun merged commit 6519657 into apache:mainNov 13, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Migrate public endpoint Get Task to FastAPI, with main resynced
* Re-run static checks
* Remove extra router line
@omkar-foss
omkar-foss deleted the aip-84/tasks/get-task branch November 14, 2024 18:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Get Task to FastAPI

4 participants

@omkar-foss@dolfinus@pierrejeambrun@dstandish