Skip to content

AIP-65: Add back DAG versioning support - #43735

Merged
ephraimbuddy merged 3 commits into
apache:mainfrom
astronomer:add-dagversioning
Nov 7, 2024
Merged

AIP-65: Add back DAG versioning support#43735
ephraimbuddy merged 3 commits into
apache:mainfrom
astronomer:add-dagversioning

Conversation

@ephraimbuddy

@ephraimbuddyephraimbuddy commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

This reverts commit b757bd8.

@ephraimbuddyephraimbuddy added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Nov 6, 2024
@ephraimbuddyephraimbuddy added the legacy api Whether legacy API changes should be allowed in PR label Nov 6, 2024
@potiuk

potiuk commented Nov 6, 2024

Copy link
Copy Markdown
Member

Yeah.. Looks like fairly reliably flaky (if we can use such oxymoron :D ).

potiuk
potiuk reviewed Nov 7, 2024
View reviewed changes
Comment threadtests/jobs/test_scheduler_job.py
potiuk
potiuk approved these changes Nov 7, 2024
View reviewed changes

@potiukpotiuk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, though i'd be more happy if this one is rebased (and tests are green) after #43771 that should fix google.auth pickiness about mocks used.

@ephraimbuddy

ephraimbuddy commented Nov 7, 2024

Copy link
Copy Markdown
ContributorAuthor

Should be good, though i'd be more happy if this one is rebased (and tests are green) after #43771 that should fix google.auth pickiness about mocks used.

Yeah, rebased, and it was green except for a Kubernetes test and task sdk test that stopped midway. Have rebased again. Let's see how it goes

@ephraimbuddy
ephraimbuddy merged commit cb23472 into apache:mainNov 7, 2024
@ephraimbuddy
ephraimbuddy deleted the add-dagversioning branch November 7, 2024 11:01
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@ephraimbuddy@ellisms
AIP-65: Add back DAG versioning support (apache#43735)
bec9f36
* AIP-65: Add back DAG versioning support
This reverts commit b757bd8.
* Minimize test changes
* Init DagBag where needed instead of using fixture
@ephraimbuddyephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 14, 2024
This was referenced Aug 11, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@bbovenzibbovenziAwaiting requested review from bbovenzi
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees

No one assigned

Labels

AIP-65: DAG history in UIall versionsIf set, the CI build will be forced to use all versions of Python/K8S/DBsarea:APIAirflow's REST/HTTP APIarea:CLIarea:db-migrationsPRs with DB migrationarea:dev-toolsarea:providersarea:Schedulerincluding HA (high availability) schedulerarea:serializationarea:task-sdkarea:webserverWebserver related Issueschangelog:skipChanges that should be skipped from the changelog (CI, tests, etc..)full tests neededWe need to run full set of tests for this PR to mergekind:documentationlegacy apiWhether legacy API changes should be allowed in PRprovider:fab

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ephraimbuddy@potiuk@jedcunningham