Uh oh!
There was an error while loading. Please reload this page.
AIP-84 Migrate test a connection to FastAPI API - #43766
Merged
pierrejeambrun merged 5 commits intoNov 12, 2024
Merged
Conversation
bugraoz93
requested review from
bbovenzi, ephraimbuddy, jscheffl, pierrejeambrun and ryanahamilton
as code ownersNovember 6, 2024 22:18
pierrejeambrun
approved these changes
Nov 7, 2024
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Nice.
One small change before we merge but looking good overall, thanks.
Uh oh!
There was an error while loading. Please reload this page.
bugraoz93force-pushed
the
feat/42594/test-connection-to-fastapi
branch
from
November 7, 2024 22:33
297740a to
0d4abeeComparepierrejeambrun
previously approved these changes
Nov 8, 2024
Uh oh!
There was an error while loading. Please reload this page.
bugraoz93force-pushed
the
feat/42594/test-connection-to-fastapi
branch
from
November 8, 2024 18:43
0d4abee to
5391f70Compareamoghrajesh
approved these changes
Nov 8, 2024
pierrejeambrun
approved these changes
Nov 12, 2024
bugraoz93force-pushed
the
feat/42594/test-connection-to-fastapi
branch
from
November 12, 2024 16:04
5391f70 to
04dbfbfComparebugraoz93force-pushed
the
feat/42594/test-connection-to-fastapi
branch
from
November 12, 2024 16:06
04dbfbf to
f275fd7Comparebugraoz93
commented
Nov 12, 2024
ContributorAuthor
Rebased and solved the conflicts. |
ellisms pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate test a connection to fastapi * Remove NotFound error from docs * Remove Validation error which is handled by fastapi * Remove async for complying convention for methods * Fix pre-commit ruff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #42594
It includes unifying parameter naming conventions for
test_connections.py^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.