AIP 84: Migrate POST ASSET EVENT legacy API to fast API. by vatsrahul1001 · Pull Request #43984 · apache/airflow

vatsrahul1001 · 2024-11-13T20:37:08Z

Migrating the connexion API for POST ASSETS EVENTS to fastAPI.

Depends on #43881
related: #43845

Swagger Specs

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

…w into AIP84-get-asset-events

…sset-events

…rflow into AIP84-get-asset-events taking latest

…e-asset-events Merging from main

pierrejeambrun

Nice thanks for the PR.

A few suggestions looking good overall :)

pierrejeambrun

One small nit to adjust and we can merge.

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* AIP-84: Migrating GET Assets to fastAPI * matching response to legacy * Adding unit tests - part 1 * Update airflow/api_fastapi/common/parameters.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fixing the dag_ids filter * fixing the dag_ids filter * Adding unit tests - part 2 * fixing unit tests & updating parameter type * review comments pierre * fixing last commit * fixing unit tests * migrating get assets events endpoint to fastapi * fixing test response * Adding tests for filtering * address review comments * fixing test parametrize * address review comments * address review comments * AIP84-create-asset-events migration implementation using fastapi * removing typo print command * remove typo print statement * address review comments * address review comments * Update airflow/api_fastapi/core_api/datamodels/assets.py Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> * address review comments --------- Co-authored-by: Amogh <amoghrajesh1999@gmail.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

amoghrajeshand others added 30 commits November 6, 2024 15:22

AIP-84: Migrating GET Assets to fastAPI
cf5218c

matching response to legacy
5a49280

Adding unit tests - part 1
962572b

Update airflow/api_fastapi/common/parameters.py
428cb6c
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>

fixing the dag_ids filter
a78d3cb

fixing the dag_ids filter
882d20c

Adding unit tests - part 2
25bb08e

Merge branch 'main' into AIP84-get-asset-to-fastapi
658479d

fixing unit tests & updating parameter type
fa0cd23

review comments pierre
dd791c2

fixing last commit
06fa0a7

Merge branch 'main' into AIP84-get-asset-to-fastapi
3bd803b

Merge branch 'main' into AIP84-get-asset-to-fastapi
fc29d7d

fixing unit tests
7a97220

migrating get assets events endpoint to fastapi
8b6b09e

Merge branch 'main' into AIP84-get-asset-events
b7aaa9d

fixing test response
b808895

Merge branch 'AIP84-get-asset-events' of github.com:astronomer/airflo…
1e18c0f
…w into AIP84-get-asset-events

Adding tests for filtering
52939e5

Merge branch 'main' of github.com:astronomer/airflow into AIP84-get-a…
08198f9
…sset-events

Merge branch 'AIP84-get-asset-to-fastapi' of github.com:astronomer/ai…
bf68954
…rflow into AIP84-get-asset-events taking latest

pushing changes from AIP84-get-asset-to-fastapi
674aff9

pushing changes from AIP84-get-asset-to-fastapi
0fac5ed

resoving conflicts with main
991edfd

resoving conflicts with main
f30956a

address review comments
255dc81

resoving conflicts with main
35ed49c

fixing test parametrize
1b84e09

Merge branch 'main' into AIP84-get-asset-events
d9f3d2f

updating sort params
60b1f2d

vatsrahul1001and others added 2 commits November 14, 2024 10:09

Merge branch 'main' into AIP84-get-asset-events
cdc0b1d

Mergering latest of AIP84-get-asset-events
9071559

vatsrahul1001 added the legacy api Whether legacy API changes should be allowed in PR label Nov 14, 2024

vatsrahul1001 added 2 commits November 14, 2024 14:35

Merge branch 'main' into AIP84-create-asset-events
e3abc2c

Merge branch 'main' into AIP84-create-asset-events
9bab906

vatsrahul1001 marked this pull request as ready for review November 14, 2024 09:49

vatsrahul1001 added 3 commits November 14, 2024 15:39

Merge branch 'main' of github.com:astronomer/airflow into AIP84-creat…
ebc2b05
…e-asset-events Merging from main

removing typo print command
fdde5ac

remove typo print statement
f671fce

pierrejeambrun reviewed Nov 14, 2024
View reviewed changes

vatsrahul1001 added 2 commits November 14, 2024 23:18

address review comments
6c8353c

merging from main
cb2210d

vatsrahul1001 requested a review from pierrejeambrun November 14, 2024 18:00

Merge branch 'main' into AIP84-create-asset-events
29b2e3e

vatsrahul1001 mentioned this pull request Nov 15, 2024
AIP-84 Migrating ASSETS to Legacy API to fastAPI #43845
Closed
2 tasks

pierrejeambrun mentioned this pull request Nov 15, 2024
AIP-84 Migrate public endpoints from api_connexion to the new Rest API #42370
Closed
1 task

pierrejeambrun reviewed Nov 15, 2024
View reviewed changes

pierrejeambrun changed the title ~~AIP 84: Migrate POST ASSET EVENTS legacy API to fast API.~~ AIP 84: Migrate POST ASSET EVENT legacy API to fast API. Nov 15, 2024

vatsrahul1001and others added 3 commits November 15, 2024 20:09

Merge branch 'main' into AIP84-create-asset-events
60c902c

address review comments
45a74d9

Merge branch 'main' into AIP84-create-asset-events
691a186

vatsrahul1001 requested a review from pierrejeambrun November 15, 2024 15:55

pierrejeambrun approved these changes Nov 15, 2024
View reviewed changes

Comment threadairflow/api_fastapi/core_api/datamodels/assets.py Outdated

vatsrahul1001and others added 3 commits November 15, 2024 21:51

Update airflow/api_fastapi/core_api/datamodels/assets.py
8af74db
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

address review comments
733db9a

Merge branch 'main' into AIP84-create-asset-events
bb64827

pierrejeambrun merged commit fd0a0d2 into apache:mainNov 15, 2024

pierrejeambrun deleted the AIP84-create-asset-events branch November 15, 2024 16:46

vatsrahul1001 mentioned this pull request Nov 15, 2024
Redact extra fields for Asset Endpoints in fastAPI #44069
Merged

Navigation Menu

Uh oh!

AIP 84: Migrate POST ASSET EVENT legacy API to fast API. - #43984

AIP 84: Migrate POST ASSET EVENT legacy API to fast API. #43984
pierrejeambrun merged 56 commits into
apache:mainfrom
astronomer:AIP84-create-asset-events

vatsrahul1001 commented Nov 13, 2024

Uh oh!

pierrejeambrun left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vatsrahul1001 commented Nov 13, 2024

Uh oh!

pierrejeambrun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pierrejeambrun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pierrejeambrun left a comment •
edited
Loading