Uh oh!
There was an error while loading. Please reload this page.
Prepare docs for Nov 1st wave of providers - #44011
Conversation
eladkal
commented
Nov 14, 2024
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Nov 14, 2024
That will also mean @eladkal that we MUST release standard provider with this wave - otherwise common won't be installable. It's currently 0.0.1 - which I think migt be a good idea to keep it at 0.* until we migrate all things out from core? |
that is the plan. This wave is pretty much all or nothing. It's 0.0.1 till we make it "stable" by extracting everything. |
Very interesting error. Side effect of another test. Fix is coming. |
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in apache#44011 in the apache#44011 (comment) Patching is now fixed via using fixtures.
potiuk
commented
Nov 14, 2024
The failure is fixed in #44029 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eladkal
commented
Nov 14, 2024
Cool so no need to regenerate docs as the fix is only in a test |
Uh oh!
There was an error while loading. Please reload this page.
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the #44011 (comment) Patching is now fixed via using fixtures.
Uh oh!
There was an error while loading. Please reload this page.
| ~~~~ | ||
| * ``Move bash operator to Standard provider (#42252)`` | ||
| * ``Purge existing SLA implementation (#42285)`` |
There was a problem hiding this comment.
Hmm this one is because https://github.com/apache/airflow/pull/42285/files#diff-8fa4fd0e9c359df89fde6c3043b13aa7d36d9f63aebc1744bffc43e00b158886L26 - i.e. removal of sla_miss documentation. This is a small thing and probably not worth reverting, but it looks like the providers affected (pagerduty, slack, smtp) will miss the sla_miss documetnation. Not a big deal, would be better to have a note instead that it wil only work in 2.0 - @ferruzzi -> not sure if this is worth the effort.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
potiuk
left a comment
There was a problem hiding this comment.
Reviewed in a pretty detailed way. Gernerally approved, but there are few questions/comments
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289