Uh oh!
There was an error while loading. Please reload this page.
Fix error propagation in new tests - #44087
Merged
Merged
Conversation
potiuk
requested review from
bugraoz93 and Copilot
and removed request for
ashbNovember 16, 2024 05:55
potiuk
requested review from
amoghrajesh, eladkal, ephraimbuddy, kaxil, rawwar, romsharon98, shahar1 and vatsrahul1001November 16, 2024 05:56
potiukforce-pushed
the
fix-error-code-propagation-in-tests
branch
from
November 16, 2024 06:14
0900de0 to
3f53375Comparepotiuk
commented
Nov 16, 2024
MemberAuthor
We will also have to merge #44088 to revert the failing API tests. |
potiuk
commented
Nov 16, 2024
MemberAuthor
Now - we detect those errors properlu. |
gopidesupavan
approved these changes
Nov 16, 2024
gopidesupavan
left a comment
Member
There was a problem hiding this comment.
LGTM, all the failing tests are related to other pr.
Lee-W
approved these changes
Nov 16, 2024
gopidesupavanforce-pushed
the
fix-error-code-propagation-in-tests
branch
from
November 16, 2024 07:34
3f53375 to
ce99b2aComparevatsrahul1001
approved these changes
Nov 16, 2024
gopidesupavan
commented
Nov 16, 2024
Member
added fix here for the failed tests: #44093 |
The apache#43979 introduced unit_tests.sh script that did not properly propagate error codes (no -e/+e setting). This PR fixes it - also fixes an edge case where the -e setting is not restored in run breeze commmand script.
gopidesupavanforce-pushed
the
fix-error-code-propagation-in-tests
branch
from
November 16, 2024 09:36
ce99b2a to
bf956aeComparejscheffl
approved these changes
Nov 16, 2024
kandharvishnu pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
The apache#43979 introduced unit_tests.sh script that did not properly propagate error codes (no -e/+e setting). This PR fixes it - also fixes an edge case where the -e setting is not restored in run breeze commmand script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #43979 introduced unit_tests.sh script that did not properly propagate error codes (no -e/+e setting).
This PR fixes it - also fixes an edge case where the -e setting is not restored in run breeze commmand script.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.