Skip to content

AIP-84: Migrating GET one queued asset events for DAG to fastAPI - #44128

Merged
amoghrajesh merged 13 commits into
apache:mainfrom
astronomer:AIP84-get-one-queued-event-for-dag-again
Nov 19, 2024
Merged

AIP-84: Migrating GET one queued asset events for DAG to fastAPI#44128
amoghrajesh merged 13 commits into
apache:mainfrom
astronomer:AIP84-get-one-queued-event-for-dag-again

Conversation

@amoghrajesh

Copy link
Copy Markdown
Contributor

related: #42370

Same setup as #44124 and dependent on #44124

Responses:

  1. Legacy
    image

  2. FastAPI
    image

With time filtering

  1. Legacy
    image

  2. FastAPI
    image

Swagger spec:
image

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@amoghrajesh

Copy link
Copy Markdown
ContributorAuthor

Only last commit is relevant

@amoghrajeshamoghrajesh self-assigned this Nov 18, 2024

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nitpick. but overall looks good

Comment threadairflow/api_fastapi/core_api/routes/public/assets.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py Outdated
amoghrajeshand others added 2 commits November 18, 2024 17:41
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one small update required, feel free to merge after

Comment threadairflow/api_fastapi/core_api/routes/public/assets.py Outdated
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@amoghrajesh
amoghrajeshforce-pushed the AIP84-get-one-queued-event-for-dag-again branch from 389d09e to 449420cCompareNovember 18, 2024 18:48
@amoghrajesh
amoghrajesh merged commit af958bb into apache:mainNov 19, 2024
@amoghrajesh
amoghrajesh deleted the AIP84-get-one-queued-event-for-dag-again branch November 19, 2024 05:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@amoghrajesh@Lee-W@pierrejeambrun