Skip to content

AIP-84: Migrating DELETE queued asset events for DAG to fastAPI - #44129

Merged
pierrejeambrun merged 8 commits into
apache:mainfrom
astronomer:AIP84-delete-all-queued-events-for-dag-again
Nov 18, 2024
Merged

AIP-84: Migrating DELETE queued asset events for DAG to fastAPI#44129
pierrejeambrun merged 8 commits into
apache:mainfrom
astronomer:AIP84-delete-all-queued-events-for-dag-again

Conversation

@amoghrajesh

Copy link
Copy Markdown
Contributor

related: #42370
Migrating delete queued asset events for DAG to fastAPI

Dependent on #44124

Same setup as #44124

Responses:

  1. Legacy
    image

  2. FastAPI
    image

With time filtering

  1. Legacy
    image

  2. FastAPI
    image

Time filtering but no queued event found

  1. Legacy
    image

  2. FastAPI
    image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajeshamoghrajesh added the legacy api Whether legacy API changes should be allowed in PR label Nov 18, 2024
@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@amoghrajeshamoghrajesh changed the title Aip84 delete all queued events for dag againAIP-84: Migrating delete queued asset events for DAG to fastAPINov 18, 2024
@amoghrajeshamoghrajesh self-assigned this Nov 18, 2024
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py
@amoghrajeshamoghrajesh changed the title AIP-84: Migrating delete queued asset events for DAG to fastAPIAIP-84: Migrating DELETE queued asset events for DAG to fastAPINov 18, 2024
Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py
@amoghrajesh

Copy link
Copy Markdown
ContributorAuthor

@Lee-W@rawwar I pushed a fix for the reviews, can you check again?

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pierrejeambrun
pierrejeambrun merged commit 6c3caa6 into apache:mainNov 18, 2024
@pierrejeambrun
pierrejeambrun deleted the AIP84-delete-all-queued-events-for-dag-again branch November 18, 2024 13:57
amoghrajesh added a commit to astronomer/airflow that referenced this pull request Nov 18, 2024
…he#44129)
* AIP-84: Migrating GET queued asset events for DAG to fastAPI
* fixing tests and server code
* fixing parameters
* fixing parameters
* AIP-84: Migrating delete queued asset events for DAG to fastAPI
* adding assert for count
* review comments from kalyan
kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024
…he#44129)
* AIP-84: Migrating GET queued asset events for DAG to fastAPI
* fixing tests and server code
* fixing parameters
* fixing parameters
* AIP-84: Migrating delete queued asset events for DAG to fastAPI
* adding assert for count
* review comments from kalyan
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@amoghrajesh@Lee-W@pierrejeambrun@rawwar