Skip to content

AIP-84: Migrating DELETE queued asset events for assets to FASTAPI - #44138

Merged
pierrejeambrun merged 9 commits into
apache:mainfrom
astronomer:AIP84-delete-assets-queued-event-new
Nov 18, 2024
Merged

AIP-84: Migrating DELETE queued asset events for assets to FASTAPI#44138
pierrejeambrun merged 9 commits into
apache:mainfrom
astronomer:AIP84-delete-assets-queued-event-new

Conversation

@vatsrahul1001

Copy link
Copy Markdown
Contributor

Related: #42370

Swagger Specs
image
image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 18, 2024
@vatsrahul1001vatsrahul1001 added legacy api Whether legacy API changes should be allowed in PR and removed legacy api Whether legacy API changes should be allowed in PR labels Nov 18, 2024
@vatsrahul1001
vatsrahul1001force-pushed the AIP84-delete-assets-queued-event-new branch from 3f13e6d to 7d7a311CompareNovember 18, 2024 13:07

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ready to merge, restarting failed checks

Comment threadtests/api_fastapi/core_api/routes/public/test_assets.py
@pierrejeambrun

Copy link
Copy Markdown
Member

Won't pass, tests need fixing

@vatsrahul1001

Copy link
Copy Markdown
ContributorAuthor

Won't pass, tests need fixing

taking a look

@pierrejeambrun
pierrejeambrun merged commit 29a30b3 into apache:mainNov 18, 2024
@pierrejeambrun
pierrejeambrun deleted the AIP84-delete-assets-queued-event-new branch November 18, 2024 18:30
kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024
…pache#44138)
* AIP84-delete-assets-queued-event migration to fastapi
* updating assets route
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vatsrahul1001@pierrejeambrun