Uh oh!
There was an error while loading. Please reload this page.
Trigger openlineage test when asset files changes - #44172
Conversation
f6f0a93 to
cbc69b5CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Nov 19, 2024
Two small comments. |
…m:astronomer/airflow into trigger-openlineage-tests-on-asset-change
vatsrahul1001
commented
Nov 20, 2024
Thank you for the suggestions. I have implemented the suggested changes. |
…m:astronomer/airflow into trigger-openlineage-tests-on-asset-change
uranusjr
commented
Nov 20, 2024
Can you elaborate what broke in OL? I’m not sure |
vatsrahul1001
commented
Nov 20, 2024
@uranusjr This issue explain more about what broke in OL. Also, this PR was raised to fix OL tests. I asked @Lee-W for the assets file we can remove these files |
Lee-W
commented
Nov 20, 2024
I believe @uranusjr's point is more convincing. Although those are related to assets, they are using assets and are unlikely to affect OL. I should have thought it through more thoroughly. |
Uh oh!
There was an error while loading. Please reload this page.
vatsrahul1001
commented
Nov 20, 2024
Thanks, @Lee-W and @uranusjr for the suggestion. I will remove |
Uh oh!
There was an error while loading. Please reload this page.
Lee-W
commented
Nov 22, 2024
@vatsrahul1001 should we resolve the discussions or are we waiting for @potiuk 's confirmation? or |
We can resolve the discussion. @potiuk, is it good to merge? |
potiuk
commented
Nov 22, 2024
Good to go, merged :) |
Description
Adding
FileGroupForCi.ASSET_FILESand running Openlineage test when Assets files are changed.Motivation:
We recently noticed PR broke OL tests as
openlineagetests heavily rely on assets and are often broken after asset changes. We want to trigger OL test whenever there is a change in Asset related files.closes: #44026
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.