Skip to content

AIP-84 Migrate XCom get entries endpoint to Fastapi - #44366

Merged
vincbeck merged 5 commits into
apache:mainfrom
michaeljs-c:migrate-xcom-getentries-to-fastapi
Nov 26, 2024
Merged

AIP-84 Migrate XCom get entries endpoint to Fastapi#44366
vincbeck merged 5 commits into
apache:mainfrom
michaeljs-c:migrate-xcom-getentries-to-fastapi

Conversation

@michaeljs-c

@michaeljs-cmichaeljs-c commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

closes: #42980

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Nov 25, 2024
@rawwarrawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 25, 2024
rawwar
rawwar reviewed Nov 25, 2024
View reviewed changes
Comment threadairflow/api_fastapi/core_api/routes/public/xcom.py Outdated
rawwar
rawwar reviewed Nov 26, 2024
View reviewed changes
Comment threadairflow/api_fastapi/core_api/routes/public/xcom.py Outdated
pierrejeambrun
pierrejeambrun reviewed Nov 26, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Looking good, just one nitpick.

We can merge when @rawwar comments are addressed.

Thanks

Comment threadtests/api_fastapi/core_api/routes/public/test_xcom.py Outdated
@michaeljs-c
michaeljs-cforce-pushed the migrate-xcom-getentries-to-fastapi branch 2 times, most recently from fc6f1c9 to b55992bCompareNovember 26, 2024 11:17
amoghrajesh
amoghrajesh reviewed Nov 26, 2024
View reviewed changes

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice @michaeljs-c! Two nits and we should be in a mergable state

Comment threadairflow/api_fastapi/core_api/routes/public/__init__.py
Comment threadtests/api_fastapi/core_api/routes/public/test_xcom.py
@michaeljs-c

michaeljs-c commented Nov 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Looking into CI failures

@jason810496

jason810496 commented Nov 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Looking into CI failures

Hi @michaeljs-c, I think the current CI failure for static is cause by frontend generated code, which could be resolve by:

pre-commit run ts-compile-format-lint-ui --all-files

refer: #43859 (comment)

@pierrejeambrunpierrejeambrun added the AIP-84 Modern Rest API label Nov 26, 2024
@pierrejeambrunpierrejeambrun added this to the Airflow 3.0.0 milestone Nov 26, 2024
@pierrejeambrunpierrejeambrun changed the title Migrate XCom get entries endpoint to FastapiAIP-84 Migrate XCom get entries endpoint to FastapiNov 26, 2024
amoghrajesh
amoghrajesh approved these changes Nov 26, 2024
View reviewed changes

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation. LGTM

@michaeljs-c
michaeljs-cforce-pushed the migrate-xcom-getentries-to-fastapi branch from b55992b to f413addCompareNovember 26, 2024 16:47
@michaeljs-c

michaeljs-c commented Nov 26, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Looking into CI failures

Hi @michaeljs-c, I think the current CI failure for static is cause by frontend generated code, which could be resolve by:

pre-commit run ts-compile-format-lint-ui --all-files

refer: #43859 (comment)

Thanks! for some reason it got skipped during my initial pre-commit

@vincbeck
vincbeck merged commit a18bcd7 into apache:mainNov 26, 2024
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@michaeljs-c@got686-yandex
AIP-84 Migrate XCom get entries endpoint to Fastapi (apache#44366)
18293f3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawwarrawwarrawwar left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@amoghrajeshamoghrajeshamoghrajesh approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bbovenzibbovenziAwaiting requested review from bbovenzi
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@jscheffljschefflAwaiting requested review from jscheffl

Assignees

No one assigned

Labels

AIP-84Modern Rest APIarea:APIAirflow's REST/HTTP APIlegacy apiWhether legacy API changes should be allowed in PR

Projects

No open projects
AIP-84 MODERN REST API
Status: Done

Milestone

Airflow 3.0.0

Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate XCom get entries public endpoint to FastAPI

6 participants

@michaeljs-c@jason810496@pierrejeambrun@rawwar@amoghrajesh@vincbeck