Skip to content

AIP-84: Migrate Dag Parsing endpoint to FastApi - #44416

Merged
pierrejeambrun merged 8 commits into
apache:mainfrom
astronomer:migrate_dag_parsing_endpoint
Nov 28, 2024
Merged

AIP-84: Migrate Dag Parsing endpoint to FastApi#44416
pierrejeambrun merged 8 commits into
apache:mainfrom
astronomer:migrate_dag_parsing_endpoint

Conversation

@prabhusneha

@prabhusnehaprabhusneha commented Nov 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Related: #42370

Testing:

API responses using legacy and fastAPI endpoints:

Legacy-API:

image
last_parsed_time changed in airflow.dag:

image

FastAPI:

image
last_parsed_time changed in airflow.dag:

image

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 27, 2024
@prabhusneha
prabhusnehaforce-pushed the migrate_dag_parsing_endpoint branch from bad0ea3 to af1827dCompareNovember 27, 2024 12:38
@rawwarrawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 27, 2024
@rawwarrawwar closed this Nov 27, 2024
@rawwarrawwar reopened this Nov 27, 2024
@rawwar

rawwar commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

closed and reopened to run tests

rawwar
rawwar reviewed Nov 27, 2024
View reviewed changes
Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py Outdated
@pierrejeambrunpierrejeambrun mentioned this pull request Nov 27, 2024
Closed
1 task
pierrejeambrun
pierrejeambrun reviewed Nov 27, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Looking good overall, just a few suggestions :)

Comment threadairflow/api_fastapi/core_api/openapi/v1-generated.yaml Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py
Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py Outdated
Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py Outdated
Comment threadtests/api_fastapi/core_api/routes/public/test_dag_parsing.py Outdated
@prabhusneha
prabhusnehaforce-pushed the migrate_dag_parsing_endpoint branch from 941c83d to 094966aCompareNovember 28, 2024 07:55
@pierrejeambrunpierrejeambrun added legacy api Whether legacy API changes should be allowed in PR and removed legacy api Whether legacy API changes should be allowed in PR labels Nov 28, 2024
@prabhusneha

prabhusneha commented Nov 28, 2024

Copy link
Copy Markdown
ContributorAuthor

Fixing the checks.

@prabhusneha
prabhusnehaforce-pushed the migrate_dag_parsing_endpoint branch from c32838e to b3b783dCompareNovember 28, 2024 11:52
rawwar
rawwar reviewed Nov 28, 2024
View reviewed changes
Comment threadtests/api_fastapi/core_api/routes/public/test_dag_parsing.py Outdated
@prabhusneha

prabhusneha commented Nov 28, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased and all PR comments addressed.. FYI @pierrejeambrun

pierrejeambrun
pierrejeambrun approved these changes Nov 28, 2024
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, ready to merge

Comment threadairflow/api_fastapi/core_api/routes/public/dag_parsing.py Outdated
@prabhusneha
prabhusnehaforce-pushed the migrate_dag_parsing_endpoint branch from 5fb527b to 5546e23CompareNovember 28, 2024 15:44
@prabhusneha
prabhusnehaforce-pushed the migrate_dag_parsing_endpoint branch from 5546e23 to 2cae524CompareNovember 28, 2024 16:14
@pierrejeambrun

pierrejeambrun commented Nov 28, 2024

Copy link
Copy Markdown
Member

Thanks!

@pierrejeambrun
pierrejeambrun merged commit 3e427c9 into apache:mainNov 28, 2024
@pierrejeambrun
pierrejeambrun deleted the migrate_dag_parsing_endpoint branch November 28, 2024 16:41
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@prabhusnehaSneha Prabhu@got686-yandex
AIP-84: Migrate Dag Parsing endpoint to FastApi (apache#44416)
8162313
* AIP-84: Migrate Dag Parsing endpoint to FastApi
* Address PR comments
* Change the test class name
* Address PR comments and fix tests
* Address PR comment
* remove database isolation option to fix failing check
* Address PR comment
---------
Co-authored-by: Sneha Prabhu <snehaprabhu@Snehas-MacBook-Pro.local>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawwarrawwarrawwar left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@bbovenzibbovenziAwaiting requested review from bbovenzi
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@jscheffljschefflAwaiting requested review from jscheffl
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@potiukpotiukAwaiting requested review from potiuk
@ashbashbAwaiting requested review from ashb
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@eladkaleladkalAwaiting requested review from eladkal
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.legacy apiWhether legacy API changes should be allowed in PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prabhusneha@rawwar@pierrejeambrun