Skip to content

Update trigger_timeout column in task_instance table to use UtcDateTime - #44507

Merged
ephraimbuddy merged 16 commits into
apache:mainfrom
astronomer:update-task-instance-trigger-timeout-to-utcdatetime
Dec 12, 2024
Merged

Update trigger_timeout column in task_instance table to use UtcDateTime#44507
ephraimbuddy merged 16 commits into
apache:mainfrom
astronomer:update-task-instance-trigger-timeout-to-utcdatetime

Conversation

@vatsrahul1001

@vatsrahul1001vatsrahul1001 commented Nov 30, 2024

Copy link
Copy Markdown
Contributor

This PR addresses comment.

closes: #44421


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vatsrahul1001
vatsrahul1001 marked this pull request as ready for review November 30, 2024 16:11

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we need to handle for mysql too?

@vatsrahul1001

Copy link
Copy Markdown
ContributorAuthor

Looks good, do we need to handle for mysql too?

In MySql, its stored as DATETIME only. I don't think so we need to handle in MySql

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
@kaxil?

@vatsrahul1001

Copy link
Copy Markdown
ContributorAuthor

LGTM +1 @kaxil?

Does this look good to you, @kaxil?

@ephraimbuddyephraimbuddy added the full tests needed We need to run full set of tests for this PR to merge label Dec 12, 2024
@ephraimbuddy
ephraimbuddy merged commit b7df463 into apache:mainDec 12, 2024
@ephraimbuddy
ephraimbuddy deleted the update-task-instance-trigger-timeout-to-utcdatetime branch December 12, 2024 11:34
ellisms pushed a commit to ellisms/airflow that referenced this pull request Dec 13, 2024
…me (apache#44507)
* update task instance trigger timeout to utcdatetime
* update task instance trigger timeout to utcdatetime
* update task instance trigger timeout to utcdatetime
* updatng task_instance file
* update migration desc
* fixing execution api test
* adding migration condition to run only for postgresql
* fix static check
* remove postgresql condition
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…me (apache#44507)
* update task instance trigger timeout to utcdatetime
* update task instance trigger timeout to utcdatetime
* update task instance trigger timeout to utcdatetime
* updatng task_instance file
* update migration desc
* fixing execution api test
* adding migration condition to run only for postgresql
* fix static check
* remove postgresql condition
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:db-migrationsPRs with DB migrationfull tests neededWe need to run full set of tests for this PR to mergekind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate TI.trigger_timeout to UtcDateTime

4 participants

@vatsrahul1001@ephraimbuddy@kaxil@amoghrajesh