Uh oh!
There was an error while loading. Please reload this page.
Raise deprecation warning when accessing metadata through str - #44791
Merged
Lee-W merged 1 commit intoDec 10, 2024
Conversation
Lee-W
requested review from
XD-DENG, ashb, bbovenzi, bolkedebruin, dstandish, eladkal, ephraimbuddy, hussein-awala, jedcunningham, jscheffl, kaxil, o-nikolas, pierrejeambrun, potiuk, ryanahamilton, uranusjr and vincbeck
as code ownersDecember 9, 2024 15:47
uranusjr
approved these changes
Dec 9, 2024
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
removed request for
ashb, bbovenzi, bolkedebruin, ephraimbuddy, kaxil, potiuk and ryanahamiltonDecember 9, 2024 20:36
uranusjr
removed request for
XD-DENG, dstandish, eladkal, hussein-awala, jedcunningham, jscheffl, o-nikolas, pierrejeambrun and vincbeckDecember 9, 2024 20:36
jscheffl
approved these changes
Dec 9, 2024
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Some tests fail but you probably know how to fix...
Lee-W
commented
Dec 10, 2024
MemberAuthor
I'm not sure at this moment 🤔 but will take a look later today |
pierrejeambrun
approved these changes
Dec 10, 2024
Lee-Wforce-pushed
the
deprecate-metadata-string-access
branch
from
December 10, 2024 09:52
fdd6217 to
79ac426Comparekaxil pushed a commit
that referenced
this pull request
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior will be removed in airflow 3 as assets have attributes name and uri, it would be confusing to identify which attribute should be used to filter the right asset
related: #43922, #44639
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.