Uh oh!
There was an error while loading. Please reload this page.
Remove reparse on DAG depending on asset alias - #44866
Merged
Merged
Conversation
Lee-W
self-requested a review
December 12, 2024 09:07
I suspect we no longer need this since alias resolution now happens very late in the scheduling process. A DAG *should* be able to automatically understand the alias is resolved without a reparse after refactorings introduced in cccc933.
uranusjrforce-pushed
the
try-no-reparse
branch
from
December 12, 2024 09:43
55990f4 to
1ce03d7Compareuranusjr
marked this pull request as ready for review
December 12, 2024 12:00
hussein-awala
approved these changes
Dec 12, 2024
Lee-W
commented
Dec 13, 2024
Member
@uranusjr would like to confirm whether it works on your local. I tried with commit |
uranusjr
commented
Dec 13, 2024
MemberAuthor
Still some problems. Don’t merge this yet. |
uranusjr
marked this pull request as draft
December 13, 2024 04:01
uranusjr
commented
Dec 16, 2024
MemberAuthor
I can’t come up with a good way to test this (our test setup does not lend well toward real scheduler isolation). I’m going to just cross fingers and merge this if @Lee-W does not reject. |
uranusjr
marked this pull request as ready for review
December 16, 2024 07:17
Lee-W
approved these changes
Dec 16, 2024
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
I suspect we no longer need this since alias resolution now happens very late in the scheduling process. A DAG *should* be able to automatically understand the alias is resolved without a reparse after refactorings introduced in cccc933.
jedcunningham added a commit
to astronomer/airflow
that referenced
this pull request
Mar 13, 2025
This functionality was removed in apache#44866, but the methods weren't removed. The reparse functionality is being refactored, so removing them is easier than repairing them.
kaxil pushed a commit
that referenced
this pull request
Mar 13, 2025
This functionality was removed in #44866, but the methods weren't removed. The reparse functionality is being refactored, so removing them is easier than repairing them.
aaron-y-chen pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Apr 4, 2025
This functionality was removed in apache#44866, but the methods weren't removed. The reparse functionality is being refactored, so removing them is easier than repairing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect we no longer need this since alias resolution now happens very late in the scheduling process. A DAG should be able to automatically understand the alias is resolved without a reparse after refactorings introduced in cccc933.
Let’s see what CI thinks.