Skip to content

AIP-84 add external dependencies asset condition - #44877

Merged
pierrejeambrun merged 2 commits into
apache:mainfrom
astronomer:AIP-84-add-external-dependencies-asset-condition
Dec 16, 2024
Merged

AIP-84 add external dependencies asset condition#44877
pierrejeambrun merged 2 commits into
apache:mainfrom
astronomer:AIP-84-add-external-dependencies-asset-condition

Conversation

@pierrejeambrun

Copy link
Copy Markdown
Member

Based on #44701.

Only last commit is relevant. Add asset-condition join nodes.

Closes: #42367

@pierrejeambrunpierrejeambrun added the AIP-84 Modern Rest API label Dec 12, 2024
@pierrejeambrunpierrejeambrun self-assigned this Dec 12, 2024
@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 12, 2024
@pierrejeambrunpierrejeambrun added this to the Airflow 3.0.0 milestone Dec 12, 2024

@jscheffljscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For last commit :-D

@pierrejeambrun
pierrejeambrunforce-pushed the AIP-84-add-external-dependencies-asset-condition branch 2 times, most recently from e829bb6 to ef8d8feCompareDecember 13, 2024 17:13
@pierrejeambrun
pierrejeambrunforce-pushed the AIP-84-add-external-dependencies-asset-condition branch from ef8d8fe to 1dd994cCompareDecember 13, 2024 17:17

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to confirm that it's expected for assets and asset-alias to appear as 'upstream' of the asset-condition. It should be consistent with the getUpstreamAssets but I just want to make sure.

(Then I make the asset condition upstream of the first node of the graph which sounds normal).

@bbovenzi

Copy link
Copy Markdown
Contributor

I just want to confirm that it's expected for assets and asset-alias to appear as 'upstream' of the asset-condition. It should be consistent with the getUpstreamAssets but I just want to make sure.

(Then I make the asset condition upstream of the first node of the graph which sounds normal).

Yes, that sounds right to me

@pierrejeambrun
pierrejeambrunforce-pushed the AIP-84-add-external-dependencies-asset-condition branch from 1dd994c to 72686abCompareDecember 16, 2024 13:47
@pierrejeambrun
pierrejeambrun merged commit 13a18c3 into apache:mainDec 16, 2024
@pierrejeambrun
pierrejeambrun deleted the AIP-84-add-external-dependencies-asset-condition branch December 16, 2024 17:19
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Structure endpoint add asset-condition
* Fix CI
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-84Modern Rest APIarea:UIRelated to UI/UX. For Frontend Developers.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

AIP-84 Add external dependencies to a dag's graph_data

3 participants

@pierrejeambrun@bbovenzi@jscheffl