Skip to content

Add dependaboat to check upgrades daily - #44966

Merged
jscheffl merged 5 commits into
apache:mainfrom
gopidesupavan:add-dependaboat
Dec 17, 2024
Merged

Add dependaboat to check upgrades daily#44966
jscheffl merged 5 commits into
apache:mainfrom
gopidesupavan:add-dependaboat

Conversation

@gopidesupavan

@gopidesupavangopidesupavan commented Dec 16, 2024

Copy link
Copy Markdown
Member

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan

gopidesupavan commented Dec 16, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

We can configure if any prefix required in PR title. ?

currently it doesn't support the cron expression, so have given daily.

We have dependency in pre-commit , but unfortunately dependaboat is not supported to bump dependencies in pre-commit.

@gopidesupavangopidesupavan mentioned this pull request Dec 16, 2024
Merged
jscheffl
jscheffl approved these changes Dec 16, 2024
View reviewed changes
Comment thread.github/dependabot.yml Outdated
Comment thread.github/dependabot.yml Outdated
@gopidesupavan

gopidesupavan commented Dec 16, 2024

Copy link
Copy Markdown
MemberAuthor

Do we need to group any package updates ?

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups

https://github.blog/changelog/2023-06-30-grouped-version-updates-for-dependabot-public-beta/

gopidesupavanand others added 2 commits December 16, 2024 19:24
@gopidesupavan
add task_sdk to dependaboat directories list
579144c
@gopidesupavan@jscheffl
Update .github/dependabot.yml
1b26f56
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl
jscheffl reviewed Dec 16, 2024
View reviewed changes
Comment thread.github/dependabot.yml Outdated
@gopidesupavan@jscheffl
Remove quotes
f4c2262
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl
jscheffl approved these changes Dec 16, 2024
View reviewed changes

@jscheffljscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amoghrajesh
amoghrajesh approved these changes Dec 17, 2024
View reviewed changes

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
I say lets merge it and we can test it in real time if it works. Good job!

Comment thread.github/dependabot.yml
potiuk
potiuk reviewed Dec 17, 2024
View reviewed changes
Comment thread.github/dependabot.yml
potiuk
potiuk approved these changes Dec 17, 2024
View reviewed changes

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but added one more comment about adding ./dev/breeze as well.

@jscheffl
jscheffl merged commit 50c2c9a into apache:mainDec 17, 2024
@gopidesupavan

gopidesupavan commented Dec 17, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for the merge :) was bit of on travel today. it looks like dependaboat already started playing his role. hahah

@gopidesupavan

gopidesupavan commented Dec 17, 2024

Copy link
Copy Markdown
MemberAuthor

https://github.com/apache/airflow/pulls/app%2Fdependabot

@gopidesupavan

gopidesupavan commented Dec 17, 2024

Copy link
Copy Markdown
MemberAuthor

LGTM - but added one more comment about adding ./dev/breeze as well.

Thanks for pointing missed that :)

@gopidesupavan
gopidesupavan deleted the add-dependaboat branch December 21, 2024 05:24
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@gopidesupavan@jscheffl@got686-yandex
Add dependaboat to check upgrades daily (apache#44966)
5f15630
* add dependaboat to check upgrades daily
* add task_sdk to dependaboat directories list
* Update .github/dependabot.yml
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Remove quotes
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Update .github/dependabot.yml
---------
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jscheffljscheffljscheffl approved these changes
@amoghrajeshamoghrajeshamoghrajesh approved these changes

Assignees

No one assigned

Labels

area:dev-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gopidesupavan@potiuk@amoghrajesh@jscheffl