Uh oh!
There was an error while loading. Please reload this page.
Enforce to forbid extra fields under execution_api - #44986
Conversation
65215a4 to
0419c2bComparea0ae953 to
ac39ba4CompareAdding |
There was a problem hiding this comment.
There's a PR opened for doing that in the core_apis. More information here:
#44306
I suggest to consolidate the approach for all of our APIs.
Most likely Bodies / input payloads have forbid_extra=True, but Responses do not. (because this is useful for filtering down a subpart of a model, and this feature is used by some endpoints).
@pierrejeambrun Thanks for sharing issue.
I'll review the shared PR and make adjustments based on it! |
ac39ba4 to
76fcae9Compare51e685a to
a358b7dCompare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice. A few suggestions, but looking good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
One test to remove and we should be good. |
jx2lee
commented
Feb 4, 2025
I'm in gym now, go back to fix soon! |
be2e289 to
c22d21aComparepierrejeambrun
commented
Feb 4, 2025
Re-running failed job |
c22d21a to
5111226Comparejx2lee
commented
Feb 5, 2025
@pierrejeambrun Do i need to modify code? |
pierrejeambrun
commented
Feb 5, 2025
CI is green, merging, thanks. |
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
* extra forbidden * test * gen_file * fix gen_file * rm clear_db_* * rm testcase * rm testcase # 2
closes: #44978
related: #44306
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.