Rename fail stop dag property to fail fast by hprassad · Pull Request #45327 · apache/airflow

hprassad · 2025-01-01T14:05:41Z

closes: #45229
This PR renames fail_stop DAG property to fail_fast, the changes made to relevant files

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

boring-cyborg · 2025-01-01T14:05:45Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

amoghrajesh · 2025-01-02T04:59:38Z

@hprassad FYI, I updated your PR description to link the issue.

Lee-W

Overall, I'm good with this PR, but we'll need a newsfragment for it

amoghrajesh

There are a couple of occurences which have been missed in tests.
Ref:

Also, needs a newsfragment addition. Example: https://github.com/apache/airflow/pull/43902/files#diff-802ca1cc091ad2e4489cfdb8cb02678d0bc42db3a6b9081859a2ee66b415b94e

amoghrajesh · 2025-01-02T07:12:04Z

@Lee-W do we have to add this one into migration rules too?

Lee-W · 2025-01-02T09:47:35Z

@Lee-W do we have to add this one into migration rules too?

Yes, this can be easily detected. I’ll create a PR for this later

potiuk · 2025-01-02T12:37:25Z

@hprassad - I rebased it -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests.

Lee-W

I think we'll need newsfragment for this one

https://github.com/apache/airflow/blob/main/contributing-docs/16_contribution_workflow.rst#step-4-prepare-pr

amoghrajesh

Yeah the changes look good @hprassad. Can you please add newsfragment as mentioned by @Lee-W?

hprassad · 2025-01-03T18:14:57Z

@amoghrajesh & @Lee-W , I have added file in newsfragments folder for the PR

amoghrajesh

One nit, but looks good to me! Thanks @hprassad!

I would also wait for approval from @Lee-W on this.

amoghrajesh · 2025-01-17T03:57:46Z

@hprassad Few checks are failing. Can you please take a look and fix it?

amoghrajesh · 2025-01-20T05:34:24Z

@hprassad gentle ping. Could you please handle the review comments and rebase this Pull Request? We are waiting on this one for #44951

Lee-W · 2025-01-20T09:50:57Z

@amoghrajesh I just updated it. Please take a final look. Once this is merged, I'll create a ruff PR for migration rule. Thanks!

amoghrajesh

One comment, otherwise looks good

boring-cyborg · 2025-01-21T02:04:44Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

amoghrajesh · 2025-01-21T05:06:32Z

@hprassad congratulations on your first PR merge! 🥇

* Renamed fail_stop DAG property to fail_fast (apache#45229) * made changes to missed occurences (apache#45229) * Renamed fail_stop DAG property to fail_fast (apache#45229) * Added newsfragments for the PR apache#45327 * docs(newsfragment): update change type and migraiton rule * ci(github-actions): fix ci typo --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>

hprassad requested review from XD-DENG and ashb as code owners January 1, 2025 14:05

boring-cyborgBot added the area:task-sdk label Jan 1, 2025

amoghrajesh requested review from Lee-W, amoghrajesh and uranusjr January 2, 2025 04:59

Lee-W added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Jan 2, 2025

Lee-W reviewed Jan 2, 2025
View reviewed changes

amoghrajesh reviewed Jan 2, 2025
View reviewed changes

potiuk force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from b92cd31 to d108d45Compare January 2, 2025 12:37

hprassad requested review from Lee-W and amoghrajesh January 2, 2025 14:08

Lee-W reviewed Jan 3, 2025
View reviewed changes

amoghrajesh reviewed Jan 3, 2025
View reviewed changes

hprassad added a commit to hprassad/airflow that referenced this pull request Jan 3, 2025
Added newsfragments for the PRapache#45327
5ce5ec6

hprassad requested review from Lee-W and amoghrajesh January 4, 2025 06:40

amoghrajesh approved these changes Jan 7, 2025
View reviewed changes

Comment threadnewsfragments/45327.significant.rst Outdated

eladkal added this to the Airflow 3.0.0 milestone Jan 13, 2025

amoghrajesh mentioned this pull request Jan 20, 2025
Handle fail_stop / non teardown tasks in TASK SDK #44951
Closed

hprassad added 2 commits January 20, 2025 17:38

Renamed fail_stop DAG property to fail_fast (apache#45229)
53965a8

made changes to missed occurences (apache#45229)
ebc833b

hprassad added 2 commits January 20, 2025 17:39

Renamed fail_stop DAG property to fail_fast (apache#45229)
22f215c

Added newsfragments for the PRapache#45327
6a43e77

Lee-W force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from 2952acc to d25c241Compare January 20, 2025 09:50

Lee-W approved these changes Jan 20, 2025
View reviewed changes

Lee-W requested a review from potiuk as a code owner January 20, 2025 09:53

amoghrajesh approved these changes Jan 20, 2025
View reviewed changes

Comment threadnewsfragments/45327.significant.rst Outdated

Lee-W added 2 commits January 20, 2025 18:19

docs(newsfragment): update change type and migraiton rule
353ec8e

ci(github-actions): fix ci typo
2fae4f2

Lee-W force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from aed2f42 to 2fae4f2Compare January 20, 2025 10:19

Merge branch 'main' into rename-fail_stop-DAG-property-to-fail_fast
5daf253

Lee-W approved these changes Jan 21, 2025
View reviewed changes

Lee-W merged commit a76af4f into apache:mainJan 21, 2025

Uh oh!

Conversation

hprassad commented Jan 1, 2025• edited by amoghrajesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boring-cyborgBot commented Jan 1, 2025

Uh oh!

amoghrajesh commented Jan 2, 2025

Uh oh!

Lee-W left a comment

Choose a reason for hiding this comment

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

amoghrajesh commented Jan 2, 2025

Uh oh!

Lee-W commented Jan 2, 2025

Uh oh!

potiuk commented Jan 2, 2025

Uh oh!

Lee-W left a comment

Choose a reason for hiding this comment

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

hprassad commented Jan 3, 2025

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amoghrajesh commented Jan 17, 2025

Uh oh!

amoghrajesh commented Jan 20, 2025

Uh oh!

Lee-W commented Jan 20, 2025

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

boring-cyborgBot commented Jan 21, 2025

Uh oh!

amoghrajesh commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hprassad commented Jan 1, 2025•
edited by amoghrajesh
Loading