Uh oh!
There was an error while loading. Please reload this page.
AIP-72: Add support for outlet_events in Task Context - #45727
Merged
Conversation
kaxil
requested review from
ashb, bolkedebruin, ephraimbuddy and pierrejeambrun
as code ownersJanuary 17, 2025 00:28
ashb
commented
Jan 17, 2025
Member
Did you consider sending these via the initial context we send in the response to the Run request? |
ashb
reviewed
Jan 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
ashb
reviewed
Jan 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
ashb
reviewed
Jan 17, 2025
Uh oh!
There was an error while loading. Please reload this page.
ashb
approved these changes
Jan 17, 2025
ashb
left a comment
Member
There was a problem hiding this comment.
A couple of comments/alternate URL designs, but code LGTM
part of apache#45717 This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
kaxil
commented
Jan 17, 2025
MemberAuthor
Following failure is unrelated |
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Jan 17, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Jan 18, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
Comment on lines
+793
to
+800
| elif isinstance(msg, GetAssetByName): | ||
| asset_resp = self.client.assets.get(name=msg.name) | ||
| asset_result = AssetResult.from_asset_response(asset_resp) | ||
| resp = asset_result.model_dump_json(exclude_unset=True).encode() | ||
| elif isinstance(msg, GetAssetByUri): | ||
| asset_resp = self.client.assets.get(uri=msg.uri) | ||
| asset_result = AssetResult.from_asset_response(asset_resp) | ||
| resp = asset_result.model_dump_json(exclude_unset=True).encode() |
Contributor
There was a problem hiding this comment.
I was just wondering what would happen if both were provided. Nicely handled
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Jan 20, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
kaxil added a commit
to astronomer/airflow
that referenced
this pull request
Jan 20, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
kaxil added a commit
that referenced
this pull request
Jan 20, 2025
Follow-up of #45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
dauinh pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
part of apache#45717 and apache#45752 This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
dauinh pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
part of apache#45717 and apache#45752 This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
got686-yandex pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
niklasr22 pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
part of apache#45717 and apache#45752 This PR adds support for `outlet_events` in Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.
niklasr22 pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
Follow-up of apache#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 28, 2025
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 21, 2025
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 26, 2026
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 27, 2026
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
kosteev pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 29, 2026
Follow-up of apache/airflow#45727 to use Protocol to allow auto-completion on IDE while not introducing runtime dep GitOrigin-RevId: 08d0273c1a88333f504913ae7b35ddb0414f24b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #45717
This PR adds support for
outlet_eventsin Context dict within the Task SDK by adding an endpoint on the API Server which is fetched when outlet_events is accessed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.