Connect Trigger UI Conf with the flexible form - #45790

Merged

jscheffl merged 22 commits into

apache:mainfrom

shubhamraj-git:connect_trigger_conf

Jan 25, 2025

shubhamraj-git commented Jan 19, 2025•
edited by jscheffl
Loading

Contributor

This PR is the continuation of #45270 by @jscheffl

Future Work (Not decided, might need discussion):

Introduce a reset button
Have a asterisk on the accordion item which contains a required field inside.
If we face error when Trigger button when clicked, related field should turn in error mode.

closes: #22408 #44858

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

shubhamraj-git added 7 commits

January 19, 2025 03:42

centralised setup

310e7ca

refactor

cc2071d

remove param pass

98dbbf3

remove reset

5783574

date time fix

0f496a9

refactor

faa7c95

accordion css

ef543ba

boring-cyborgBot added the area:UI label

jscheffl reviewed

View reviewed changes

airflow/ui/package.json

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx Outdated

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldDropdown.tsx Outdated

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldNumber.tsx Outdated

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldString.tsx Outdated

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldStringArray.tsx

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx

jscheffl reviewed

View reviewed changes

jscheffl left a comment

Contributor

First pass review, am tired and need to go to bed. Will do more tests and feedback tomorrow. From dry-reading code looks already very good!

shubhamraj-gitand others added 4 commits

January 21, 2025 14:09

Merge branch 'main' into connect_trigger_conf

a8ee2d0

remove console error

aa50c80

copy params

8f72753

reviews

395c6c1

shubhamraj-git marked this pull request as ready for review

January 21, 2025 19:27

shubhamraj-git requested review from bbovenzi, pierrejeambrun and ryanahamilton as code owners

January 21, 2025 19:27

shubhamraj-gitand others added 3 commits

January 22, 2025 00:58

Merge branch 'main' into connect_trigger_conf

0263641

css alert

dc524bc

fix

1854af9

shubhamraj-git requested a review from jscheffl

January 21, 2025 20:12

jscheffl reviewed

View reviewed changes

jscheffl left a comment

Contributor

Pretty cool in the current state. Did a second pass review and some testing.

Let me know if I shall contribute fixes to your branch, I catched the idea now and before a lot of detail ping-pong I can help as well (knowing all the dirty legacy). Anyway no big problems besides the comments.

airflow/ui/src/components/FlexibleForm/FieldString.tsx Outdated

airflow/ui/src/components/FlexibleForm/FieldStringArray.tsx

airflow/ui/src/components/FlexibleForm/FieldNumber.tsx Outdated

airflow/ui/src/components/FlexibleForm/FieldMultiSelect.tsx

bbovenzi reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldAdvancedArray.tsx Outdated

airflow/ui/src/components/FlexibleForm/FieldMultiSelect.tsx

airflow/ui/src/components/FlexibleForm/FlexibleForm.tsx

airflow/ui/src/components/FlexibleForm/FieldMultiSelect.tsx

airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx

shubhamraj-gitand others added 4 commits

January 25, 2025 00:44

Merge branch 'main' into connect_trigger_conf

d841853

Merge branch 'main' into connect_trigger_conf

e3dba24

reviews regarding setting null

de891d9

refactor

95bffea

shubhamraj-git requested review from bbovenzi and jscheffl

January 24, 2025 23:45

Merge branch 'main' into connect_trigger_conf

cca1b9d

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx Outdated

jscheffl reviewed

View reviewed changes

airflow/ui/src/components/FlexibleForm/FieldObject.tsx Outdated

shubhamraj-gitand others added 3 commits

January 26, 2025 00:31

Empty Objects sets to Null

d9cbdf5

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

Fix Date and time

770f039

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

Merge branch 'main' into connect_trigger_conf

cca09fc

jscheffl approved these changes

View reviewed changes

jscheffl left a comment

Contributor

That all looks good now. THANKS!
The small glitches and improvements you also mentioned can be made in a separate PR,
Cool, Basic trigger forms are working now for the new UI!

jscheffl merged commit ba7135c into apache:main

utkarsharma2 added the type:new-feature label

utkarsharma2 added this to the Airflow 3.0.0 milestone

got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request

Connect Trigger UI Conf with the flexible form (apache#45790)

6192181

* centralised setup
* refactor
* remove param pass
* remove reset
* date time fix
* refactor
* accordion css
* remove console error
* copy params
* reviews
* css alert
* fix
* reviews regarding setting null
* refactor
* Empty Objects sets to Null
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Fix Date and time
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
---------
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request

Connect Trigger UI Conf with the flexible form (apache#45790)

58987d9

* centralised setup
* refactor
* remove param pass
* remove reset
* date time fix
* refactor
* accordion css
* remove console error
* copy params
* reviews
* css alert
* fix
* reviews regarding setting null
* refactor
* Empty Objects sets to Null
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Fix Date and time
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
---------
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request

Connect Trigger UI Conf with the flexible form (apache#45790)

4639111

* centralised setup
* refactor
* remove param pass
* remove reset
* date time fix
* refactor
* accordion css
* remove console error
* copy params
* reviews
* css alert
* fix
* reviews regarding setting null
* refactor
* Empty Objects sets to Null
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Fix Date and time
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
---------
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

shubhamraj-git deleted the connect_trigger_conf branch

September 7, 2025 19:37

pedro-cf mentioned this pull request

Trigger DAG modal: two-column layout for params (label left, control right) #67852

Closed

2 tasks

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UItype:new-feature