Skip to content

Fix pre-commit checking provider's doc consistency - #45803

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-providers-doc-check-pre-commit
Jan 20, 2025
Merged

Fix pre-commit checking provider's doc consistency#45803
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix-providers-doc-check-pre-commit

Conversation

@potiuk

Copy link
Copy Markdown
Member

The pre-commit was not working since the move of providers to the providers top-level folder (#42505) - but we also have not added many new providers since. This PR updates the check to work again only for providers that follow the new structure and to be more verbose on what it is doing.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
potiuk requested a review from ashb as a code ownerJanuary 20, 2025 15:43
@boring-cyborgboring-cyborgBot added area:dev-tools provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Jan 20, 2025
@potiuk
potiukforce-pushed the fix-providers-doc-check-pre-commit branch from ab62bef to 77f4688CompareJanuary 20, 2025 15:44
@potiuk

Copy link
Copy Markdown
MemberAuthor

Example output:

image

The pre-commit was not working since the move of providers to
the `providers` top-level folder (apache#42505) - but we also have
not added many new providers since. This PR updates the check
to work again only for providers that follow the new structure
and to be more verbose on what it is doing.
@potiuk
potiukforce-pushed the fix-providers-doc-check-pre-commit branch from 77f4688 to b798421CompareJanuary 20, 2025 16:28
@potiuk
potiuk merged commit 6b2462f into apache:mainJan 20, 2025
@potiuk
potiuk deleted the fix-providers-doc-check-pre-commit branch January 20, 2025 16:53
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
The pre-commit was not working since the move of providers to
the `providers` top-level folder (apache#42505) - but we also have
not added many new providers since. This PR updates the check
to work again only for providers that follow the new structure
and to be more verbose on what it is doing.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
The pre-commit was not working since the move of providers to
the `providers` top-level folder (apache#42505) - but we also have
not added many new providers since. This PR updates the check
to work again only for providers that follow the new structure
and to be more verbose on what it is doing.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
The pre-commit was not working since the move of providers to
the `providers` top-level folder (apache#42505) - but we also have
not added many new providers since. This PR updates the check
to work again only for providers that follow the new structure
and to be more verbose on what it is doing.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-toolsprovider:edgeEdge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@potiuk@eladkal