Uh oh!
There was an error while loading. Please reload this page.
ci(github-actions): add a script to check significant newsfragments - #46007
Merged
Conversation
Lee-Wforce-pushed
the
check-newsfragments
branch
from
January 24, 2025 09:09
047b0a7 to
21bf3c4CompareUh oh!
There was an error while loading. Please reload this page.
vincbeck
approved these changes
Jan 27, 2025
potiuk
commented
Jan 27, 2025
Member
Why not pre-commit ? you will be able to run it locally way before it even hits the CI. |
Lee-Wforce-pushed
the
check-newsfragments
branch
from
February 3, 2025 06:13
21bf3c4 to
3eff24dCompareLee-W
commented
Feb 3, 2025
MemberAuthor
Yep, sounds like a great idea! I just updated it to use pre-commit. Will merge it once the CI pass so that we can ensure the format is correct for future newsfragments. |
Lee-Wforce-pushed
the
check-newsfragments
branch
2 times, most recently
from
February 3, 2025 06:44
67aa17f to
637ed20CompareLee-Wforce-pushed
the
check-newsfragments
branch
2 times, most recently
from
February 3, 2025 08:36
17ea46c to
0ee5f07CompareLee-Wforce-pushed
the
check-newsfragments
branch
from
February 3, 2025 09:11
0ee5f07 to
9db8814CompareLee-W
commented
Feb 3, 2025
MemberAuthor
as the ci failure has nothing to do with it and will be fixed by #46368. I'll go ahead and merge this PR |
dabla pushed a commit
to dabla/airflow
that referenced
this pull request
Feb 3, 2025
…pache#46007) * ci(github-acitons): add script to check significant newsfragments * docs(newsfragments): fix incorrect format * docs(newsfragments): upgrade api-66.significant format * ci(pre-commit): add x mod to significant_newsfragments_checker.py
ambika-garg pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 4, 2025
…pache#46007) * ci(github-acitons): add script to check significant newsfragments * docs(newsfragments): fix incorrect format * docs(newsfragments): upgrade api-66.significant format * ci(pre-commit): add x mod to significant_newsfragments_checker.py
niklasr22 pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…pache#46007) * ci(github-acitons): add script to check significant newsfragments * docs(newsfragments): fix incorrect format * docs(newsfragments): upgrade api-66.significant format * ci(pre-commit): add x mod to significant_newsfragments_checker.py
ambika-garg pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#46007) * ci(github-acitons): add script to check significant newsfragments * docs(newsfragments): fix incorrect format * docs(newsfragments): upgrade api-66.significant format * ci(pre-commit): add x mod to significant_newsfragments_checker.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #45740, we further formalize the significant newsfragments format but have not yet added a script to check it in CI.
What
A script is added for checking whether the format is correct, allow us to export summarization of these newsfragments and list down undone migration rules
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.