Uh oh!
There was an error while loading. Please reload this page.
Move SMTP Provider to new structure - #46067
Conversation
shubhamraj-git
commented
Jan 26, 2025
@hussein-awala I see we have DRAFT PR which relates to SMTP Provider, this migration can create conflicts. Are you okay with it or should we postpone this migration till you merge your PR? |
hussein-awala
left a comment
There was a problem hiding this comment.
As the process of moving a provider is almost automated (according to some comments from Jarek in other PRs if I'm not mistaken), I prefer to wait until the other PR is merged.
shubhamraj-git
commented
Jan 26, 2025
Yes, It's an automated process. I can do it post your PR gets merged. |
potiuk
commented
Jan 26, 2025
Yeah. It looks like we could start to batch those changes - since they are generating conflicts. |
potiuk
commented
Jan 27, 2025
Maybe we can merge it anyway. It will be rather easy to rebase your PR @hussein-awala and we still need to agree on the change from your PR :) |
o-nikolas
commented
Jan 30, 2025
Given that the email discussions are still ongoing and the PR remains in draft. Shall we merge this one? |
jscheffl
left a comment
There was a problem hiding this comment.
Anything holding us back? I think this looks good to merge.
hussein-awala
commented
Jan 30, 2025
I split my PR into many smaller ones, I need to merge #46219 before rebasing and merging this one. I'll try to fix the failing tests tomorrow or Saturday. |
potiuk
commented
Feb 7, 2025
Instead of rebasing it I created #46556 anew - it seems that it should work out of the box - easier than solve conflicts with this one. |
shubhamraj-git
commented
Feb 7, 2025
@potiuk Yaa, thanks! |
related to #46045
We have a DRAFT PR opened yesterday which affects SMTP Provider by @hussein-awala
breeze testing providers-tests --test-type 'Providers[ssh]'^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.