Add Task Instance clear for mapped task summaries by bbovenzi · Pull Request #48584 · apache/airflow

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi · 2025-03-31T15:02:03Z

On the Mapped Task Summary details page, add a Clear button to clear all the mapped tasks at once.

This PR also updated the Mark As button too, but there seems to be an API issue that prevents bulk marking state from working so the button is commented out with a TODO

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

jscheffl

Looks good in my view! LGTM!

jscheffl · 2025-03-31T19:08:30Z

- <ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
+ <ActionAccordion
+ affectedTasks={affectedTasks}
+ note={taskNote === undefined ? undefined : note}


I briefly thought about if it would make sense to keep the notes fied and if all are cleared then the note is applied to all mapped tasks?
But not critical / blocking. Can also be adjusted in future.

Mark state as and setting a note are the same patch endpoint which doesn't work right now.

If I remember correctly you need to pass a tuple somewhere.
I’ll double check tomorrow. Otherwise I think we should fix the backend

Oh that’s the bulk patch ? Anyway I need to check the code tomorrow

Cool. I'll hold off. It would be great to have this all at once instead of refactoring again later.

Added to my todo list, I'll work on the backend part soon.

github-actions · 2025-05-23T00:17:39Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

pierrejeambrun · 2025-05-23T13:17:48Z

ping

pierrejeambrun · 2025-05-23T13:20:30Z

The backend has been implemented, both in:

Calling the regular patch ti with map_index=None should patch all the related map index (summary).

bbovenzi · 2025-05-29T16:31:40Z

Closing and will redo to try to use Row Selection too

bbovenzi requested review from jscheffl, pierrejeambrun and ryanahamilton as code owners March 31, 2025 15:02

boring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 31, 2025

jscheffl approved these changes Mar 31, 2025
View reviewed changes

Add Task Instance clear for mapped task summaries
662351c

bbovenzi force-pushed the allow-clearing-all-mapped-tis-at-once branch from 374c4fe to 662351cCompare April 1, 2025 20:11

pierrejeambrun mentioned this pull request May 13, 2025
Add Patch Task Instance Summary #50526
Merged

github-actionsBot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 23, 2025

pierrejeambrun removed the stale Stale PRs per the .github/workflows/stale.yml policy file label May 23, 2025

bbovenzi closed this May 29, 2025