Rename operation IDs for task instance endpoints to include map index… - #49608

Merged
pierrejeambrun merged 13 commits into
apache:mainfrom
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged

Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom
abhishekbhakat:fix-openapi-spec-unique-operationid

Conversation

@abhishekbhakat

@abhishekbhakatabhishekbhakat commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

closes: #49607

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Apr 23, 2025
jason810496
jason810496 reviewed Apr 23, 2025
View reviewed changes

@jason810496jason810496 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )

Follow up:

I think we can add pre-commit for preventing duplicate operationId.
Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.

@bbovenzi

bbovenzi commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Can you check that BlockingDeps.tsx in the UI still works?

It should render in the "Details" tab when you have a task instance selected.

bugraoz93
bugraoz93 reviewed Apr 23, 2025
View reviewed changes

@bugraoz93bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!

@abhishekbhakat

abhishekbhakat commented Apr 23, 2025

Copy link
Copy Markdown
ContributorAuthor

Can you check that BlockingDeps.tsx in the UI still works?

It should render in the "Details" tab when you have a task instance selected.

Screenshot 2025-04-23 at 16 00 57

@bbovenzi this is what I got

@abhishekbhakat

abhishekbhakat commented Apr 23, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@bugraoz93

  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.

pierrejeambrun
pierrejeambrun approved these changes Apr 23, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.

I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).

@bugraoz93

bugraoz93 commented Apr 23, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@bugraoz93

  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.

Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test

@abhishekbhakat

abhishekbhakat commented Apr 23, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec

CC @jason810496

bugraoz93
bugraoz93 reviewed Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py Outdated
bugraoz93
bugraoz93 reviewed Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py Outdated
@ashbashb mentioned this pull request Apr 24, 2025
Merged
pierrejeambrun
pierrejeambrun approved these changes Apr 24, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@pierrejeambrun
pierrejeambrun merged commit 1cd8614 into apache:mainApr 24, 2025
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit that referenced this pull request May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit that referenced this pull request Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
This was referenced Jun 3, 2025
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi

6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rename operation IDs for task instance endpoints to include map index… - #49608
Merged
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Apr 24, 2025
Merged
Rename operation IDs for task instance endpoints to include map index…#49608
pierrejeambrun merged 13 commits into
apache:mainfrom 
abhishekbhakat:fix-openapi-spec-unique-operationid
Conversation
@abhishekbhakat
@abhishekbhakatabhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
closes: #49607
@boring-cyborgboring-cyborgBot
added
the 
area:API
Airflow's REST/HTTP API
label
Apr 23, 2025
jason810496
jason810496
reviewed
Apr 23, 2025
View reviewed changes
@jason810496jason810496
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me ( maybe rebase later once the CI is fixed. )
Follow up:
I think we can add pre-commit for preventing duplicate operationId.

Maybe not a new one, adding validate_spec in generate-openapi-spec pre-commit will be enough I think.
@bbovenzi
bbovenzi
commented
Apr 23, 2025

Copy link


Copy Markdown

Contributor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
@bugraoz93bugraoz93
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As mentioned, revase, fix CI, and manual tests would be awesome. Thanks for the pr!
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025

Copy link


Copy Markdown

ContributorAuthor
Can you check that BlockingDeps.tsx in the UI still works?
It should render in the "Details" tab when you have a task instance selected.
Screenshot 2025-04-23 at 16 00 57
@bbovenzi this is what I got
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
pierrejeambrun
pierrejeambrun
approved these changes
Apr 23, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested locally and working.
I don't think we need unit test for that. I think what Bugra was referring to manual testing. (verifying in the UI that everything looks correct for marking a mapped task and normal task as success or failure, as well as updating the task notes).
@bugraoz93
bugraoz93
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
@bugraoz93
  • The CI failing is not related to this PR. I'll have to just wait till they are fixed.
  • To add the tests, I might need to add the openapi-spec-validator in the deps. Let me know if that's ok I'll add it.
Yeah, I wasn't on the computer, checked it now :) Yes, as Pierre mentioned, I meant the manual test
@abhishekbhakat
abhishekbhakat
commented
Apr 23, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Added validation of openapi spec logic in the run_update_fastapi_api_spec.py so now it runs with pre-commit hook generate-openapi-spec
CC @jason810496
bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

bugraoz93
bugraoz93
reviewed
Apr 23, 2025
View reviewed changes
Comment threadscripts/in_container/run_update_fastapi_api_spec.py
Outdated

@ashbashb
mentioned this pull request
Apr 24, 2025
 Merged

pierrejeambrun
pierrejeambrun
approved these changes
Apr 24, 2025
View reviewed changes
@pierrejeambrunpierrejeambrun
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.
@pierrejeambrun
pierrejeambrun
merged commit 1cd8614
into
apache:mainApr 24, 2025
prabhusneha pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
@abhishekbhakatSneha Prabhu
Rename operation IDs for task instance endpoints to include map index… (
c72c04e
apache#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
kaxil pushed a commit
that referenced
this pull request
May 16, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
377160c
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)
kaxil pushed a commit
that referenced
this pull request
Jun 3, 2025
@abhishekbhakat@kaxil
Rename operation IDs for task instance endpoints to include map index… (
13d7332
#49608)
* Rename operation IDs for task instance endpoints to include map index for openapi spec validator
* refactor: Update TaskInstanceService methods and types to use map index for dependencies
* Add OpenAPI validation to FastAPI spec generation script
* refactor: streamline OpenAPI validation process by removing redundant exit checks
(cherry picked from commit 1cd8614)

This was referenced Jun 3, 2025

Closed

 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffljscheffl is a code owner
@potiukpotiukAwaiting requested review from potiukpotiuk is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavangopidesupavan is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP API

Projects


None yet


Milestone

Airflow 3.0.2

Development

Successfully merging this pull request may close these issues.

Unique operationId in openapi


6 participants

@abhishekbhakat@bbovenzi@bugraoz93@pierrejeambrun@jason810496@kaxil