Uh oh!
There was an error while loading. Please reload this page.
Misc spelling updates - #5
Conversation
There was a problem hiding this comment.
This creates a spelling error, rather than correcting it
mistercrunch
commented
Jun 6, 2015
Woah. I didn't realize how much typos there was in there. I clearly need some sort of spell checker plugin in my vim. I'll merge as soon as you update the one thing @Mause pointed out. Thanks! |
eerwitt
commented
Jun 6, 2015
None hurt my ability to use airflow, they seemed extremely minor to me. I noticed because my poor spelling caused frustration for an english as a second language colleague so I added these lines to my vimrc: hiclearSpellBadhiSpellBad cterm=underlinesetspellspelllang=en_usIt works pretty well for me with PyMode and not correcting |
mistercrunch
commented
Jun 7, 2015
Nice, I dropped those lines in my .vimrc and it seems to work well with my python config. Expect less typos from me in the future! Merging. |
# This is a combination of 16 commits. # This is the 1st commit message: Add flask_admin_unescape function to airfow.www.utils # This is the commit message apache#2: Add flask_admin_unescape to TaskInstanceModelView for task_id and dag_id # This is the commit message apache#3: Add test_flask_admin_unescape to tests.www.test_utils # This is the commit message apache#4: Add TestTaskInstanceModelView to tests.www.test_views This test for the proper integration between Subdag Tasks and the flask_admin package. Because the flask_admin package uses '.' characters as it's escape character and airflow enforces the dag_id.subdag_id format for the dag_id's for task_id's in subdags, the escaping that flask_admin preforms causes a duplication of the '.' character. When perform the actions that are available for those task_instances via the ui, this causes an error. These tests are here to protect against that integration issue. # This is the commit message apache#5: Update airflow.www.utils to conform to flake8 standards # This is the commit message apache#6: Update tests.www.test_utils to conform to flake8 standards # This is the commit message apache#7: Update TestTaskInstanceModelView to Leverage assertEqual # This is the commit message apache#8: Remove Superfluous SubDAG Task Var TestTaskInstanceModelView # This is the commit message apache#9: Update airflow.www.utils.gizipped.view_func to match with flake8 # This is the commit message apache#11: Update airflow.www._connection_ids to align with flake8 spacing # This is the commit message apache#12: Update tests.www.test_utils.test_flask_admin_unescape with proper spaces # This is the commit message apache#13: Align tests.www.test_views with flake8 standards # This is the commit message apache#14: Remove unnecessary SubDagOperator in tests.www.test_views # This is the commit message apache#15: Change Position on install_aliases call in www.utils for flake8 # This is the commit message apache#16: Separate setting subdag state via flask_admin model tests
…_pandas_gbq Added a workaround for a pandas_gbq issue when result table has 1 column
…-2817 to develop * commit '768ee500963cab7b5e2172b871cfe0889da7a257': Bump version to 1.8.0-up1.2.0 DATA-2817: support celery worker --hostname arg
* Add circle_ci config * Add basic circleCI template * Add an integration-test target * Sample fix * Adding additional dependency in test-requirements * Add testing line * Add some install steps to install airflow for testing * Adjustments to install local airflow to run tests * Add additional necessary requirements * Add circle_ci fixes
add community link
# This is the 1st commit message: added hook,operator,unit test,system test, docs for google cloud log sink. # This is the commit message #2: updated docs and provider yml # This is the commit message apache#3: system test for happy path # This is the commit message apache#4: updated porvder ynl # This is the commit message apache#5: full and final code # This is the commit message apache#6: ruff formatting # This is the commit message apache#7: updated licesne
chore(deps): update dependency @types/node to v11.13.19
I was reading over the code to understand how everything works and ended up making minor spelling changes. None stopped functionality for me except a change in the iPython Notebook. I hope these changes might be useful.
This is an extremely helpful utility and a cool use of DAGs.