') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [AIP-86] Add deadline to DAG model by ferruzzi · Pull Request #50093 · apache/airflow · GitHub
Skip to content

[AIP-86] Add deadline to DAG model - #50093

Merged
ferruzzi merged 9 commits into
apache:mainfrom
aws-mwaa:ferruzzi/deadlines/add-deadline-to-dag-model
May 15, 2025
Merged

[AIP-86] Add deadline to DAG model#50093
ferruzzi merged 9 commits into
apache:mainfrom
aws-mwaa:ferruzzi/deadlines/add-deadline-to-dag-model

Conversation

@ferruzzi

@ferruzziferruzzi commented May 1, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

First step in AIP-86 to add Deadline Alerts. Plenty more to come, but I wanted to break it down into reasonable bites for easier review.

This PR adds the new Deadline field to the DAG database table, a new model to handle the Deadline, and the unit tests to cover those additions. The next PR (already queued up once this is merged) will implement the DeadlineTrigger class which I sketched out in this one.

Example usage:

@task
def hello():
log.info('hello world')
with DAG(
dag_id='dag_with_deadline',
deadline=DeadlineAlert(
trigger=DeadlineTrigger.DagrunExecutionDate,
interval=timedelta(hours=1),
callback=hello,
)
):
hello()

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@ferruzzi

ferruzzi commented May 1, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like I need to add a db migration for the DateTime => DateTimeUTC type change. Fix coming.

@ferruzzi
ferruzzi requested review from o-nikolas and vincbeckMay 1, 2025 19:33
vincbeck
vincbeck reviewed May 1, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/models/deadline.py Outdated
o-nikolas
o-nikolas reviewed May 1, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/migrations/versions/0070_3_1_0_change_deadline_to_utc.py Outdated
o-nikolas
o-nikolas approved these changes May 6, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/models/deadline.py Outdated
@ferruzzi
ferruzziforce-pushed the ferruzzi/deadlines/add-deadline-to-dag-model branch from 18e226d to b3e2426CompareMay 6, 2025 23:06
@eladkal
eladkal self-requested a review May 8, 2025 15:23
@ferruzziferruzzi added this to the Airflow 3.1.0 milestone May 8, 2025
@ferruzziferruzzi mentioned this pull request May 12, 2025
Closed
1 task
1fanwang
1fanwang approved these changes May 14, 2025
View reviewed changes

@1fanwang1fanwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM, left minor comments mostly for my learning.

Comment threadairflow-core/src/airflow/models/dag.py
Comment threadairflow-core/src/airflow/models/deadline.py Outdated
Comment threadairflow-core/src/airflow/models/deadline.py Outdated
@ferruzzi
Add deadline to DAG model
caecb02
Example usage:
```
@task
def hello():
log.info('hello world')
with DAG(
dag_id='dag_with_deadline',
deadline=DeadlineAlert(
trigger=DeadlineTrigger.DAGRUN_LOGICAL_DATE,
interval=timedelta(hours=1),
callback=hello_callback,
)
):
hello()
```
@ferruzzi
Add db migration for converting the deadline column, which will sto…
eb97e7b
…re a calculated datetime/timestamp, from DateTime to DateTimeUTC.
@ferruzzi
rename DeadlineTrigger (and related variable names) to DeadlineReference
46d7e6f
@ferruzzi
remove unused log import
303ca54
@ferruzzi
rebase and clear merge conflicts
b4b3670
@ferruzzi
ferruzziforce-pushed the ferruzzi/deadlines/add-deadline-to-dag-model branch from 11c7872 to 49ed943CompareMay 15, 2025 00:39
@ferruzzi

ferruzzi commented May 15, 2025

Copy link
Copy Markdown
ContributorAuthor

rebased to clear merge conflicts again

o-nikolas
o-nikolas reviewed May 15, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/models/deadline.py
Comment threadairflow-core/src/airflow/models/deadline.py Outdated
ramitkataria
ramitkataria approved these changes May 15, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/utils/module_loading.py
@ferruzziferruzzi mentioned this pull request May 15, 2025
Closed
1 task
@ferruzzi
ferruzzi merged commit 4a2cb2f into apache:mainMay 15, 2025
@ferruzzi
ferruzzi deleted the ferruzzi/deadlines/add-deadline-to-dag-model branch May 15, 2025 22:28
@rawwarrawwar mentioned this pull request May 21, 2025
Closed
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
@ferruzzi@sanederchik
[AIP-86] Add deadline to DAG model (apache#50093)
8c9a3ba
* Add deadline to DAG model
Example usage:
```
@task
def hello():
log.info('hello world')
with DAG(
dag_id='dag_with_deadline',
deadline=DeadlineAlert(
trigger=DeadlineTrigger.DAGRUN_LOGICAL_DATE,
interval=timedelta(hours=1),
callback=hello_callback,
)
):
hello()
```
@amoghrajeshamoghrajesh mentioned this pull request Aug 12, 2025
Merged
kaxil added a commit to astronomer/airflow that referenced this pull request Sep 26, 2025
@kaxil
Add back Deprecation warning for sla_miss_callback
aec4b3e
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
@kaxilkaxil mentioned this pull request Sep 26, 2025
Merged
amoghrajesh pushed a commit that referenced this pull request Sep 26, 2025
@kaxil
Add back Deprecation warning for sla_miss_callback (#56127)
9cd9c9f
This was removed in #50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@kaxil@dabla
Add back Deprecation warning for sla_miss_callback (apache#56127)
054d860
This was removed in apache#50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
kaxil added a commit that referenced this pull request Oct 21, 2025
@kaxil
Add back Deprecation warning for sla_miss_callback (#56127)
cefb383
This was removed in #50093 -- I assume by mistake! Adding this back to not break das of people migration from Airflow 2.x
(cherry picked from commit 9cd9c9f)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@o-nikolaso-nikolaso-nikolas approved these changes
@vincbeckvincbeckvincbeck approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@eladkaleladkalAwaiting requested review from eladkal
+2 more reviewers
@1fanwang1fanwang1fanwang approved these changes
@ramitkatariaramitkatariaramitkataria approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:DAG-processingarea:db-migrationsPRs with DB migrationarea:serializationarea:task-sdkkind:documentation

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ferruzzi@1fanwang@ramitkataria@o-nikolas@vincbeck