Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Update TaskLogContent to support virtualized rendering - #50746

Merged
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log
May 29, 2025
Merged

Update TaskLogContent to support virtualized rendering#50746
bbovenzi merged 2 commits into
apache:mainfrom
guan404ming:refactor-ti-log

Conversation

@guan404ming

@guan404mingguan404ming commented May 18, 2025

Copy link
Copy Markdown
Member

Related Issue

#50333
cc @bbovenzi@pierrejeambrun

Why

The log rendering would be quite slow or even crash browser when rendering large logs on the frontend

How

By using @tanstack/react-virtual to support virtualized rendering, I mostly follow this official example to implement. I choose to use dynamic rendering instead of specifying fixed height since our log would have different height.

--> about 7x speed up (for 10000 logs on my local machine and tested 10 times)
Calculated from the moment the browser logs the parsed logs to the console until it’s finally rendered on the screen. Although this isn’t perfectly precise, it still gives a simple metric to confirm that our speed-up trend is positive.

before -> avg 7s

Screen.Recording.2025-05-18.at.3.38.53.PM.mov

after -> avg 1s

Screen.Recording.2025-05-18.at.3.37.58.PM.mov

Minor change: add accept field for useLog, which make us to support ndjson easily by changing the field value and adding parse func for it after it is fully supported in the future.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 18, 2025
@guan404ming
guan404ming marked this pull request as draft May 18, 2025 08:24
@jscheffl

Copy link
Copy Markdown
Contributor

Cool! I feel not confident to review but very great improvement!
Test needs to be fixed though.

@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks! I'm still trying to figure out how to test virtualized list.

@aritra24

Copy link
Copy Markdown
Collaborator

Nice change! Good job!

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx Outdated
@guan404ming
guan404ming marked this pull request as ready for review May 18, 2025 17:06
@guan404ming
guan404mingforce-pushed the refactor-ti-log branch 4 times, most recently from 3e1bc49 to 2a9eb7bCompareMay 22, 2025 17:15
@bbovenzibbovenzi added this to the Airflow 3.1.0 milestone May 22, 2025
Comment threadairflow-core/src/airflow/ui/src/queries/useLogs.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx Outdated
@guan404ming

guan404ming commented May 25, 2025

Copy link
Copy Markdown
MemberAuthor

Currently the list is worked in large monitor as in the small screen

Here are screenshots on 27 inch monitor
image
image

Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@bbovenzi

Copy link
Copy Markdown
Contributor

Looks good overall. Just one nit.

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

@guan404ming

guan404ming commented May 29, 2025

Copy link
Copy Markdown
MemberAuthor

And then, I wonder if we want this in 3.0.2 instead of 3.1.0? Its an enhancement, not a new feature.

I think it should go into 3.0.2 since it doesn’t affect how users interact with the component. I’d consider it more of an enhancement for ux. Imo the new feature would be the upcoming ndjson-related changes after #49470

@bbovenzi
bbovenzi merged commit 813f3e3 into apache:mainMay 29, 2025
github-actionsBot pushed a commit that referenced this pull request May 29, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

StatusBranchResult
v3-0-testPR Link

@guan404ming
guan404ming deleted the refactor-ti-log branch May 29, 2025 14:42
@guan404ming

Copy link
Copy Markdown
MemberAuthor

Thanks!

@jason810496

Copy link
Copy Markdown
Member

Big thanks @guan404ming 🙌 That's a fantastic improvement, really appreciate your work on this!

pierrejeambrun pushed a commit that referenced this pull request Jun 3, 2025
…50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
kaxil pushed a commit that referenced this pull request Jun 3, 2025
…50746) (#51202)
* Fix OpenAPI schema for `get_log` API (#50547)
* Fix openapi schema for get_log API
* Fix test_log
(cherry picked from commit 08cc57d)
* [v3-0-test] Update `TaskLogContent` to support virtualized rendering (#50746)
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
(cherry picked from commit 813f3e3)
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
---------
Co-authored-by: LIU ZHE YOU <68415893+jason810496@users.noreply.github.com>
Co-authored-by: Guan Ming(Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
jose-lehmkuhl pushed a commit to jose-lehmkuhl/airflow that referenced this pull request Jul 11, 2025
* Update TaskLogContent to support virtualized rendering
* Update TaskLogPreview and Logs to handle undefined parsedLogs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@guan404ming@jscheffl@aritra24@bbovenzi@jason810496