') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add bulk TI deletion UI by guan404ming · Pull Request #51564 · apache/airflow · GitHub
Skip to content

Add bulk TI deletion UI - #51564

Closed
guan404ming wants to merge 8 commits into
apache:mainfrom
guan404ming:bulk-ti-ui
Closed

Add bulk TI deletion UI#51564
guan404ming wants to merge 8 commits into
apache:mainfrom
guan404ming:bulk-ti-ui

Conversation

@guan404ming

@guan404mingguan404ming commented Jun 10, 2025

Copy link
Copy Markdown
Member

Related PR

How

  • add multi-select in ti table
  • minor fix in bulk TI deletion endpoint
Screen.Recording.2025-06-10.at.4.40.43.PM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Jun 10, 2025
@guan404ming
guan404mingforce-pushed the bulk-ti-ui branch 2 times, most recently from 1adc30a to 3376842CompareJune 10, 2025 10:15
jscheffl
jscheffl reviewed Jun 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated
@guan404ming
guan404ming marked this pull request as draft June 11, 2025 19:02
bbovenzi
bbovenzi reviewed Jun 12, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated
@guan404ming

guan404ming commented Jun 12, 2025

Copy link
Copy Markdown
MemberAuthor

I have updated the translation and try reuse AffectedTasks
Current ui looks like:

Screen.Recording.2025-06-13.at.2.39.31.AM.mov

@guan404ming
guan404ming marked this pull request as ready for review June 12, 2025 18:56
bbovenzi
bbovenzi reviewed Jun 12, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstances/DeleteTaskInstancesButton.tsx Outdated
bbovenzi
bbovenzi reviewed Jun 12, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx Outdated
bbovenzi
bbovenzi reviewed Jun 12, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated
@pierrejeambrunpierrejeambrun added this to the Airflow 3.1.0 milestone Jun 13, 2025
pierrejeambrun
pierrejeambrun reviewed Jun 13, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For mapped task instance the confirmation table is not correct, cf screenshot, actually 4 TIs are selected (3 mapped TI and 1 non mapped TI), and the modal only show 2 TIs)
Screenshot 2025-06-13 at 15 41 51

pierrejeambrun
pierrejeambrun reviewed Jun 13, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated
@guan404ming
guan404ming requested a review from Lee-W as a code ownerJune 13, 2025 15:08
@guan404ming

guan404ming commented Jun 13, 2025

Copy link
Copy Markdown
MemberAuthor

For mapped task instance the confirmation table is not correct, cf screenshot, actually 4 TIs are selected (3 mapped TI and 1 non mapped TI), and the modal only show 2 TIs)

The api needs some modification for handling ti with map_index as well. Let me mark this as draft.

@guan404ming
guan404ming marked this pull request as draft June 13, 2025 15:10
@pierrejeambrun

pierrejeambrun commented Jun 16, 2025•
edited
Loading

Copy link
Copy Markdown
Member

The api needs some modification for handling ti with map_index as well. Let me mark this as draft.

Thanks @guan404ming, do not hesitate to create a different PR for the backend part so it's easier to review and merge. (and you can rebase this branch on top of the backend change to test it locally)

@kaxilkaxil modified the milestones: Airflow 3.1.0, Airflow 3.1+Sep 9, 2025
pierrejeambrun
pierrejeambrun reviewed Sep 16, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in #50165 to fix #50104 to try to get feature parity with 2.x.

The goal was to be able to remove both TIs and DagRuns.

It seems like the singular TI deletion is already in our UI and API

Yes, as well as singular dag run. Both in API and UI.

-1. We should never delete TIs and TIH. This shouldn't even be a feature in the API!

@ashb I guess this also goes for dag runs. Should we go ahead and remove all of that from API and UI ?

cc: @bbovenzi

@ashb

ashb commented Sep 16, 2025

Copy link
Copy Markdown
Member

I guess it's up to users if they want to do it, but we should probably make it 100% clear it will delete all history and audit records of the TI.

I don't personally like it, but now I think about it more I'm not sure that we should stop users from being able to do this if they want to.

Maybe a future change to add a config option to disable deleteing them at the deploy level

@bbovenzi

bbovenzi commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

I guess it's up to users if they want to do it, but we should probably make it 100% clear it will delete all history and audit records of the TI.

I don't personally like it, but now I think about it more I'm not sure that we should stop users from being able to do this if they want to.

Maybe a future change to add a config option to disable deleteing them at the deploy level

How about we update the copy "This will remove all metadata related" and spell out what will be deleted?

@FrankPortman

FrankPortman commented Sep 25, 2025

Copy link
Copy Markdown

Not being able to easily sort/search-by-params/delete runs/TIs in bulk is a big con of AF3 for our use case.

@pierrejeambrun

pierrejeambrun commented Sep 30, 2025

Copy link
Copy Markdown
Member

@guan404ming any progress on this one ? I think a UI warning could suffice as mentioned by Brent, and unblock this.

@guan404ming

guan404ming commented Oct 2, 2025

Copy link
Copy Markdown
MemberAuthor

@guan404ming any progress on this one ? I think a UI warning could suffice as mentioned by Brent, and unblock this.

Sure! I'm also agree with this solution. I've update the warning to a more detailed version, please let me if it could be better. Thanks!

pierrejeambrun
pierrejeambrun reviewed Oct 13, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts Outdated
Comment threadairflow-core/src/airflow/ui/src/queries/useBulkPatchTaskInstances.ts Outdated
@guan404ming
guan404ming marked this pull request as draft October 15, 2025 08:28
@guan404ming
guan404ming marked this pull request as ready for review December 10, 2025 10:13
@guan404ming

guan404ming commented Dec 10, 2025

Copy link
Copy Markdown
MemberAuthor

I've updated to work with new endpoint. Please take another look, thanks!

pierrejeambrun
pierrejeambrun reviewed Dec 10, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my end, the mark as 'success' 'delete' is not working everytime. Request goes to the backend, and is successful, but it's just not updating the state of the tasks.

Screen.Recording.2025-12-10.at.15.59.45.mov

Also deleting a TI can leave a 'unfound tasks' in the UI, here task 1 was deleted.

Image

I think there are a lot of edge cases to consider, and we need extensive testing / fixes for it to work. This is a complex feature to get right.

Also the crosshair is truncated

Image

Comment threadairflow-core/src/airflow/ui/src/components/MarkAs/TaskInstances/MarkTaskInstancesAsDialog.tsx
Comment on lines +92 to +103
</Dialog.Header>

<Dialog.CloseTrigger />

<Dialog.Body width="full">
<ActionAccordion affectedTasks={affectedTasks} note={note} setNote={setNote} />
<Flex justifyContent="end" mt={3}>
<Button colorPalette="blue" loading={isPending} onClick={() => handlePatch(selectedState)}>
{translate("modal.confirm")}
</Button>
</Flex>
</Dialog.Body>

@pierrejeambrunpierrejeambrunDec 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing the selector,

Image

@pierrejeambrunpierrejeambrunDec 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's fine for now since we use the 'bulk' endpoint.

Comment threadairflow-core/src/airflow/ui/src/queries/useBulkDeleteTaskInstances.ts
Comment on lines +42 to +49
const onSuccess = async (responseData: { delete?: { errors: Array<unknown>; success: Array<string> } }) => {
const queryKeys = [
[useTaskInstanceServiceGetTaskInstancesKey],
dagId === undefined || dagRunId === undefined
? []
: [UseGridServiceGetGridTiSummariesKeyFn({ dagId, runId: dagRunId })],
];

@pierrejeambrunpierrejeambrunDec 10, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grid is not updated after a successful delete. We should probably do that too. cf video. (clearing tasks from the same run)

Comment threadairflow-core/src/airflow/ui/src/queries/useBulkPatchTaskInstances.ts
Comment on lines +43 to +46
const queryKeys = [
[useTaskInstanceServiceGetTaskInstancesKey],
dagId === undefined || dagRunId === undefined
? []

@pierrejeambrunpierrejeambrunDec 10, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@Lee-W

Lee-W commented Jan 9, 2026

Copy link
Copy Markdown
Member

@guan404ming would like to follow up whehter wer're still working on this one?

@Lee-W

Lee-W commented Jan 9, 2026

Copy link
Copy Markdown
Member

I'm now making it a draft. Feel free to mark it as ready

@Lee-W
Lee-W marked this pull request as draft January 9, 2026 08:18
@guan404ming

guan404ming commented Jan 17, 2026

Copy link
Copy Markdown
MemberAuthor

Apologies for the delay. This PR has become stale, and I noticed there are other active PRs addressing the same issue. To avoid redundancy, I’ll go ahead and close this one. Thank you everyone for your time and reviews.

@guan404ming

guan404ming commented Jan 17, 2026

Copy link
Copy Markdown
MemberAuthor

I think splitting this into several PRs is a better approach. I’ll figure out the remaining gaps and open targeted PRs accordingly. I’m also happy to help review other open PRs for this feature to avoid overlapping work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashbashbashb left review comments
@bbovenzibbovenzibbovenzi left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jscheffljscheffljscheffl left review comments
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@rawwarrawwarAwaiting requested review from rawwar
@jason810496jason810496Awaiting requested review from jason810496jason810496 is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@Lee-WLee-WAwaiting requested review from Lee-WLee-W is a code owner
@henry3260henry3260Awaiting requested review from henry3260henry3260 will be requested when the pull request is marked ready for reviewhenry3260 is a code owner
@vatsrahul1001vatsrahul1001Awaiting requested review from vatsrahul1001vatsrahul1001 will be requested when the pull request is marked ready for reviewvatsrahul1001 is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 will be requested when the pull request is marked ready for reviewchoo121600 is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

9 participants

@guan404ming@pierrejeambrun@phanikumv@ashb@bbovenzi@FrankPortman@Lee-W@jscheffl@kaxil