Uh oh!
There was an error while loading. Please reload this page.
Drop support for Python 3.9 - #52072
Conversation
potiuk
commented
Jun 23, 2025
👀 |
potiuk
commented
Jun 23, 2025
3.9 is also hard-coded in a few github action workflows where it had to be added by hand (because you cannot run breeze before you install breeze to check which version of python is supported :D ) . Classic chicken-egg |
f1a79b8 to
f4590e6CompareUh oh!
There was an error while loading. Please reload this page.
389da96 to
54587d1Comparegopidesupavan
commented
Jun 26, 2025
indeed :) |
ALMOST ... -> the (reverted) main issue AND one static check - sorting imports !!! VERY, VERY CLOSE :) |
amoghrajesh
left a comment
There was a problem hiding this comment.
Very very close! I will take another look when CI is green!
eladkal
commented
Jun 27, 2025
It's very hard to keep this PR green. For example the current failure is new, it started today and the fix applied in #52321 is insufficient for Python 3.10 because we need TypeAlias. Kindly asking reviewers to review early so we can merge this fast. |
Uh oh!
There was an error while loading. Please reload this page.
gopidesupavan
left a comment
There was a problem hiding this comment.
Thanks Elad.
LGTM, mostly type changes ;)
potiuk
commented
Jun 27, 2025
Looks good (minus the current failures of course so indeed we should merge it quickly) - reviewed with There will be cherry-pick issues, but it's inevitable and we should just let peopel know to pay attention to the kinds of changes that they are expected to "revert" when cherry-picking. |
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks fine to me. It mainly looks like type checking has had an impact, rest is pretty ok +1
potiuk
commented
Jun 27, 2025
👀 👀 .... and I might be able to complete 3.13 as a follow up.... |
potiuk
commented
Jun 27, 2025
Wooohoooo ! |
gopidesupavan
commented
Jun 27, 2025
Cool :) |
jscheffl
commented
Jun 27, 2025
Cool! |
bugraoz93
commented
Jun 27, 2025
Awesome! |
Discussion: https://lists.apache.org/thread/0th63mgfc51jy7bch032hskbgoyzyhs2
Lazy consensus: https://lists.apache.org/thread/5b3w2ofb2hjqcszkd21sg815rc0yxovt