Uh oh!
There was an error while loading. Please reload this page.
[HelmChart] Refactor container lifecycle test - #52299
Merged
Merged
Conversation
Miretpl
marked this pull request as ready for review
June 26, 2025 18:11
Miretpl
requested review from
dstandish, hussein-awala and jedcunningham
as code ownersJune 26, 2025 18:11
ContributorAuthor
Also, I noticed that bot is not adding the |
Miretplforce-pushed
the
refactor-container-lifecycle-test
branch
from
June 27, 2025 20:02
15bd757 to
9f73e1bCompareMiretplforce-pushed
the
refactor-container-lifecycle-test
branch
from
July 16, 2025 15:22
2803191 to
cd765a5CompareMiretpl
commented
Jul 16, 2025
ContributorAuthor
Hi @dstandish@jedcunningham, could you take a look at this PR? |
potiuk
approved these changes
Jul 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
karenbraganz pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #51460 I noticed that the container lifecycle tests contain unused parameters and do not test
postStartlifecycle type. This PR refactors these tests.Additionally, I added to the values.schema.json and values.yaml more precise information regarding the deprecation of theI removed that change. I noticed that there are a lot of missing deprecations, and I will prepare a separate PR for them in the future.workers.securityContextfield.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.