Skip to content

Remove Legacy Query Object Usage from airflow-models - #52325

Merged
uranusjr merged 36 commits into
apache:mainfrom
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged

Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom
Prab-27:remove-session-query-from-airflow-models

Conversation

@Prab-27

@Prab-27Prab-27 commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Related discussion: here

This PR is part of the migration to SQLAlchemy 2.0

Replaced instances of session.query() with select() constructs
Updated methods like XComModel.get_many to return Select objects instead of Query objects
Adjusted dependent code to reflect the updated return types

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch from 72b046a to 67e0627CompareJune 28, 2025 09:28
jason810496
jason810496 reviewed Jun 29, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?

@Prab-27

Prab-27 commented Jun 30, 2025

Copy link
Copy Markdown
ContributorAuthor

Converting into draft until green checks

@Prab-27
Prab-27 marked this pull request as draft June 30, 2025 14:39
@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch from 67e0627 to bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun reviewed Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py Outdated
@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch from 4910c67 to bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27 commented Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py Outdated
@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch 2 times, most recently from 335c872 to 34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch 4 times, most recently from 3fe6087 to 00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed the remove-session-query-from-airflow-models branch from 98ed7a3 to 432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr merged commit 2357f96 into apache:mainSep 2, 2025
107 checks passed
@jason810496

jason810496 commented Sep 3, 2025

Copy link
Copy Markdown
Member

#protm

Thank you again for your consistent work @Prab-27.

@Prab-27

Prab-27 commented Sep 3, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!

@Prab-27

Prab-27 commented Sep 3, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

One remaining Query-related section—I'll address it soon

@Prab-27Prab-27 mentioned this pull request Dec 14, 2025
Closed
74 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove Legacy Query Object Usage from airflow-models by Prab-27 · Pull Request #52325 · apache/airflow · GitHub
Skip to content
Remove Legacy Query Object Usage from airflow-models - #52325
Merged
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Sep 2, 2025
Merged
Remove Legacy Query Object Usage from airflow-models#52325
uranusjr merged 36 commits into
apache:mainfrom 
Prab-27:remove-session-query-from-airflow-models
Conversation
@Prab-27
@Prab-27Prab-27
commented
Jun 27, 2025

Copy link


Copy Markdown

Contributor
Related discussion: here
This PR is part of the migration to SQLAlchemy 2.0
Replaced instances of session.query() with select() constructs

Updated methods like XComModel.get_many to return Select objects instead of Query objects

Adjusted dependent code to reflect the updated return types
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
72b046a to
67e0627CompareJune 28, 2025 09:28
jason810496
jason810496
reviewed
Jun 29, 2025
View reviewed changes
@jason810496jason810496
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you help to make the CI green?
@Prab-27
Prab-27
commented
Jun 30, 2025

Copy link


Copy Markdown

ContributorAuthor
Converting into draft until green checks
@Prab-27
Prab-27
marked this pull request as draft
June 30, 2025 14:39
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
67e0627 to
bc302b0CompareJune 30, 2025 14:42
pierrejeambrun
pierrejeambrun
reviewed
Jul 4, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
4910c67 to
bd99c84CompareJuly 5, 2025 17:41
Prab-27
Prab-27
commented
Jul 5, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
Outdated

@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
2 times, most recently
from
335c872 to
34b3863CompareJuly 21, 2025 17:10
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
4 times, most recently
from
3fe6087 to
00158d5CompareAugust 3, 2025 03:49
@Prab-27
execute select function from tests and fix a test for dxcom-deserials…
c86f88e
…ed function
@Prab-27
remove .mappings()
a47f1cc
@Prab-27
fix tests
5e0c6e0
@Prab-27
remove .mappings() from cncf/test_pod.py
3a3cb3c
@Prab-27
fix some checks
8d3c0d4
@Prab-27
add path to pre-commit hook
4d1344a
@Prab-27
use / in path
e581c1d
@Prab-27
use AIRFLOW_V_3_1_PLUS version in test_backend
6a80c90
@Prab-27
add version and fix chnages
548361b
@Prab-27
Resolve conflicts
06e3297
@Prab-27
remove session.query()
37254ee
@Prab-27
fix tests
7a91031
@Prab-27
apply comment
c4cf286
@Prab-27
add session as attribute in DagRunWaiter class
bf1d52a
@Prab-27
resolve conflict
663d6c9
@Prab-27
Remove debug print statements
747c730
@Prab-27
adjust import statements and remove same code
0d7679a
@Prab-27
Customize the conditions
6e61285
@Prab-27
rearrange tests from test_pod.py
3fb04c5
@Prab-27
refactored conditional logic
d81f3b4
@Prab-27
remove unused session arguments from xcom_query function
d7d4bfc
@Prab-27
remove blank lines and add select_from
2e68baa
@Prab-27
fix static checks
432672c
@Prab-27
Prab-27force-pushed
the
remove-session-query-from-airflow-models
branch
from
98ed7a3 to
432672cCompareSeptember 2, 2025 12:24
@uranusjr
uranusjr
merged commit 2357f96
into
apache:mainSep 2, 2025

107 checks passed

@jason810496
jason810496
commented
Sep 3, 2025

Copy link


Copy Markdown

Member
#protm
Thank you again for your consistent work @Prab-27.
@Prab-27
Prab-27
commented
Sep 3, 2025

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot for reviewing this PR—I'm working on the next step and excited to contribute more!
@Prab-27
Prab-27
commented
Sep 3, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
One remaining Query-related section—I'll address it soon
@Prab-27Prab-27
mentioned this pull request
Dec 14, 2025

Closed

74 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@pierrejeambrunpierrejeambrunpierrejeambrun left review comments
@jason810496jason810496jason810496 approved these changes
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@hussein-awalahussein-awalaAwaiting requested review from hussein-awalahussein-awala is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersarea:serializationarea:Triggererprovider:common-io

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Prab-27@jason810496@uranusjr@pierrejeambrun