Skip to content

Fix static failures on main - #52887

Merged
kaxil merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/main
Jul 4, 2025
Merged

Fix static failures on main#52887
kaxil merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/main

Conversation

@vincbeck

Copy link
Copy Markdown
Contributor

Static checks are failing on main due to #52768. Fixing it


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kaxil
kaxil merged commit 92e6729 into apache:mainJul 4, 2025
@bugraoz93

Copy link
Copy Markdown
Contributor

Thanks for the fix, Vincent! I saw green on the CI. Strange.

@potiuk

potiuk commented Jul 5, 2025

Copy link
Copy Markdown
Member

Sometimes. When you rebase or force push or reopen, Github Action go into a race condition that they do not actually start the "real" tests - only sometimes run a few of the internal tests (mergabilty etc.)

Such PR will be green - but will have just 3 or 4 checks. This is exactly what happened

I raised that issue 3 or 4 years ago to Github, that status "green" when non all expected tests had even a chance to run is a bad idea - but it's still unresolved.

It happens very rarely though.

@potiuk

potiuk commented Jul 5, 2025

Copy link
Copy Markdown
Member

that's the right screenshot:

Screenshot 2025-07-05 at 09 14 07

You can see when you click "vie details" on the last action in merged PR.

@vincbeck
vincbeck deleted the vincbeck/main branch October 1, 2025 16:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vincbeck@bugraoz93@potiuk@eladkal@kaxil