Skip to content

Add search filter for DAG runs by triggering user name - #53652

Merged
pierrejeambrun merged 4 commits into
apache:mainfrom
dheerajturaga:trigger-user-api-backend
Aug 4, 2025
Merged

Add search filter for DAG runs by triggering user name#53652
pierrejeambrun merged 4 commits into
apache:mainfrom
dheerajturaga:trigger-user-api-backend

Conversation

@dheerajturaga

@dheerajturagadheerajturaga commented Jul 22, 2025

Copy link
Copy Markdown
Member

This PR adds a new search capability to filter DAG runs by the user who triggered them, providing better visibility and management of workflow executions.

imageimage

Changes Made

Backend:

  • Added triggering_user_name_pattern parameter to the /api/v2/dags/{dag_id}/dagRuns endpoint
  • Implements server-side SQL LIKE pattern matching with wildcard support (%, _)
  • Updated OpenAPI specification with proper parameter documentation

Frontend:

  • Added new search input field in the DAG Runs page alongside existing filters
  • Integrated with existing URL state management and pagination reset logic
  • Added internationalization support with "Search by Triggering User" placeholder

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Jul 22, 2025
jason810496
jason810496 reviewed Jul 23, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR.
Would you mind to add a small test for the new added query parameter?

@dheerajturaga

dheerajturaga commented Jul 24, 2025

Copy link
Copy Markdown
MemberAuthor

@jason810496 Done!

pierrejeambrun
pierrejeambrun reviewed Jul 25, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice addition, thanks.

Working as expected, just a couple of comments.

Comment threadairflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/DagRuns.tsx
@dheerajturaga

dheerajturaga commented Jul 26, 2025

Copy link
Copy Markdown
MemberAuthor

@pierrejeambrun I made the changes. Please let me know if they are good

pierrejeambrun
pierrejeambrun reviewed Jul 28, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the last commit and I still see the placeholder being truncated, is that working on your end ?

Beside this all looks good.

Screenshot 2025-07-28 at 16 09 09

pierrejeambrun
pierrejeambrun reviewed Jul 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/SearchBar.tsx Outdated
@dheerajturaga

dheerajturaga commented Jul 28, 2025

Copy link
Copy Markdown
MemberAuthor

I pulled the last commit and I still see the placeholder being truncated, is that working on your end ?

Beside this all looks good.

Screenshot 2025-07-28 at 16 09 09

Not sure why it shows up that way for you. Im not able to reproduce it even if I resize my window
image

@dheerajturaga

dheerajturaga commented Jul 30, 2025

Copy link
Copy Markdown
MemberAuthor

@pierrejeambrun if the current changes are satisfactory, can we merge?

jscheffl
jscheffl approved these changes Jul 31, 2025
View reviewed changes

@jscheffljscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.1.0 milestone Aug 1, 2025
pierrejeambrun
pierrejeambrun reviewed Aug 1, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using google chrome. On safari I noticed that the input issue is not there and all looks good. Do you also experience the problem if you use chrome?

Might be browser related

pierrejeambrun
pierrejeambrun reviewed Aug 1, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/DagRuns.tsx Outdated
@dheerajturaga

dheerajturaga commented Aug 2, 2025

Copy link
Copy Markdown
MemberAuthor

I'm using google chrome. On safari I noticed that the input issue is not there and all looks good. Do you also experience the problem if you use chrome?

Might be browser related

image

@pierrejeambrun Chrome/firefox looks good on my end. I just matched he search box implementation of Search Dags. Let me know if this is satisfactory. Happy to try something else aswell if you thing it could be better

pierrejeambrun
pierrejeambrun approved these changes Aug 4, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I still have the placeholder issue, but that might be related to macOS or to my local setup. I'll merge we can fix that later. (We will have that issue with other input box and translations, because words could be longer in other languages and that could show up too)

@pierrejeambrun
pierrejeambrun merged commit 28c0420 into apache:mainAug 4, 2025
103 checks passed
@dheerajturaga
dheerajturaga deleted the trigger-user-api-backend branch August 4, 2025 20:44
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
@dheerajturaga@ferruzzi
Add search filter for DAG runs by triggering user name (apache#53652)
aa95965
* Add Triggering User search field backend implementation
* Add tests
* Pierre's Suggestions
* Cleanup search box size logic
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
@dheerajturaga@fweilun
Add search filter for DAG runs by triggering user name (apache#53652)
93183d8
* Add Triggering User search field backend implementation
* Add tests
* Pierre's Suggestions
* Cleanup search box size logic
@dheerajturagadheerajturaga mentioned this pull request Sep 18, 2025
Closed
15 tasks
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 22, 2025
@kaxil
Update Python Client to 3.1.0rc1
e62c042
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)
## New Features:
- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))
## New API Endpoints:
- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))
## Deprecations:
- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))
## Bug Fixes:
- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
@kaxilkaxil mentioned this pull request Oct 22, 2025
Merged
kaxil added a commit to apache/airflow-client-python that referenced this pull request Oct 23, 2025
@kaxil
Update Python Client to 3.1.0rc1 (#138)
241405e
(from https://github.com/apache/airflow/tree/python-client/3.1.0rc1)
## New Features:
- Add `map_index` filter to TaskInstance API queries ([#55614](apache/airflow#55614))
- Add `has_import_errors` filter to Core API GET /dags endpoint ([#54563](apache/airflow#54563))
- Add `dag_version` filter to get_dag_runs endpoint ([#54882](apache/airflow#54882))
- Implement pattern search for event log endpoint ([#55114](apache/airflow#55114))
- Add asset-based filtering support to DAG API endpoint ([#54263](apache/airflow#54263))
- Add Greater Than and Less Than range filters to DagRuns and Task Instance list ([#54302](apache/airflow#54302))
- Add `try_number` as filter to task instances ([#54695](apache/airflow#54695))
- Add filters to Browse XComs endpoint ([#54049](apache/airflow#54049))
- Add Filtering by DAG Bundle Name and Version to API routes ([#54004](apache/airflow#54004))
- Add search filter for DAG runs by triggering user name ([#53652](apache/airflow#53652))
- Enable multi sorting (AIP-84) ([#53408](apache/airflow#53408))
- Add `run_on_latest_version` support for backfill and clear operations ([#52177](apache/airflow#52177))
- Add `run_id_pattern` search for Dag Run API ([#52437](apache/airflow#52437))
- Add tracking of triggering user to Dag runs ([#51738](apache/airflow#51738))
- Expose DAG parsing duration in the API ([#54752](apache/airflow#54752))
## New API Endpoints:
- Add Human-in-the-Loop (HITL) endpoints for approval workflows ([#52868](apache/airflow#52868), [#53373](apache/airflow#53373), [#53376](apache/airflow#53376), [#53885](apache/airflow#53885), [#53923](apache/airflow#53923), [#54308](apache/airflow#54308), [#54310](apache/airflow#54310), [#54723](apache/airflow#54723), [#54773](apache/airflow#54773), [#55019](apache/airflow#55019), [#55463](apache/airflow#55463), [#55525](apache/airflow#55525), [#55535](apache/airflow#55535), [#55603](apache/airflow#55603), [#55776](apache/airflow#55776))
- Add endpoint to watch dag run until finish ([#51920](apache/airflow#51920))
- Add TI bulk actions endpoint ([#50443](apache/airflow#50443))
- Add Keycloak Refresh Token Endpoint ([#51657](apache/airflow#51657))
## Deprecations:
- Mark `DagDetailsResponse.concurrency` as deprecated ([#55150](apache/airflow#55150))
## Bug Fixes:
- Fix dag import error modal pagination ([#55719](apache/airflow#55719))
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@jscheffljscheffljscheffl approved these changes
@bbovenzibbovenziAwaiting requested review from bbovenzibbovenzi is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:default

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dheerajturaga@pierrejeambrun@jason810496@jscheffl