Skip to content

Correct typo in get_log_url_from_ti - #54248

Closed
jessicaschueler wants to merge 1 commit into
apache:mainfrom
jessicaschueler:patch-1
Closed

Correct typo in get_log_url_from_ti#54248
jessicaschueler wants to merge 1 commit into
apache:mainfrom
jessicaschueler:patch-1

Conversation

@jessicaschueler

@jessicaschuelerjessicaschueler commented Aug 7, 2025

Copy link
Copy Markdown

Add forward slash in front of dags to get_log_url_from_ti method to return usable URL.

Closes#54247

@boring-cyborg

boring-cyborgBot commented Aug 7, 2025

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

amoghrajesh
amoghrajesh reviewed Aug 8, 2025
View reviewed changes
Comment threadtask-sdk/src/airflow/sdk/execution_time/task_runner.py
f"?try_number={try_number_value}" if try_number_value is not None and try_number_value > 0 else ""
)
_log_uri = f"{base_url}dags/{ti.dag_id}/runs/{run_id}/tasks/{ti.task_id}{map_index}{try_number}"
_log_uri = f"{base_url}/dags/{ti.dag_id}/runs/{run_id}/tasks/{ti.task_id}{map_index}{try_number}"

@amoghrajeshamoghrajeshAug 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the default value, it may make sense but for user supplied values, we should ideally do:

if not base_url.endswith("/"):
base_url += "/"

@amoghrajeshamoghrajeshAug 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a test in task-sdk/tests/task_sdk/execution_time/test_task_runner.py?

@tirkarthitirkarthiAug 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rstrip and always add slash could be another approach.

task-sdk/src/airflow/sdk/execution_time/execute_workload.py: default_execution_api_server = f"{base_url.rstrip('/')}/execution/"
airflow-core/src/airflow/executors/local_executor.py: default_execution_api_server = f"{base_url.rstrip('/')}/execution/"

@amoghrajeshamoghrajeshAug 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can be done too. @jessicaschueler can we make those changes?

@amoghrajeshamoghrajesh added this to the Airflow 3.0.5 milestone Aug 8, 2025
@kaxilkaxil mentioned this pull request Aug 13, 2025
Merged
@kaxil

kaxil commented Aug 13, 2025

Copy link
Copy Markdown
Member

Related PRs:

@kaxilkaxil mentioned this pull request Aug 13, 2025
Closed
@eladkaleladkal mentioned this pull request Aug 22, 2025
Closed
2 tasks
@AlexisNeiraSonos

AlexisNeiraSonos commented Aug 22, 2025

Copy link
Copy Markdown

Thank you @mandeepzemo@eladkal for your quick response! I’ll keep an eye on the next release!

@jessicaschueler@eladkal
Correct typo in get_log_url_from_ti
f32d8e5
Add forward slash in front of `dags` to `get_log_url_from_ti` method to return usable URL.
kaxil added a commit to astronomer/airflow that referenced this pull request Sep 15, 2025
@kaxil
Fix task log URL generation with various base_url formats
1932712
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixesapache#54247Closesapache#54248
@kaxilkaxil mentioned this pull request Sep 15, 2025
Merged
@kaxilkaxil removed this from the Airflow 3.1.0 milestone Sep 15, 2025
kaxil added a commit to astronomer/airflow that referenced this pull request Sep 15, 2025
@kaxil
Fix task log URL generation with various base_url formats
28ea70a
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixesapache#54247Closesapache#54248Closesapache#53884
@kaxilkaxil closed this in 3e16382Sep 15, 2025
kaxil added a commit that referenced this pull request Sep 15, 2025
@kaxil
Fix task log URL generation with variousbase_urlformats (#55699)
24ad1b6
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes#54247Closes#54248Closes#53884
(cherry picked from commit 3e16382)
kaxil added a commit that referenced this pull request Sep 15, 2025
@kaxil
Fix task log URL generation with variousbase_urlformats (#55699)
0956035
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes#54247Closes#54248Closes#53884
(cherry picked from commit 3e16382)
yash1thsa pushed a commit to yash1thsa/airflow that referenced this pull request Sep 16, 2025
@kaxil@yash1thsa
Fix task log URL generation with variousbase_urlformats (apache#5…
dcb6138
…5699)
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixesapache#54247Closesapache#54248Closesapache#53884
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
@kaxil@suman-himanshu
Fix task log URL generation with variousbase_urlformats (apache#5…
5fb78e2
…5699)
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixesapache#54247Closesapache#54248Closesapache#53884
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 24, 2025
@kaxil
Fix task log URL generation with various base_url formats (#55699)
5332b1a
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes #54247
Closesapache/airflow#54248Closesapache/airflow#53884
(cherry picked from commit 3e1638250fb8f58a399ad8c5946dbb77a079f63d)
GitOrigin-RevId: 09560358e062f238e89018dc45dba44fb382b747
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 2, 2026
@kaxil
Fix task log URL generation with various base_url formats (#55699)
3a3a9ae
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes #54247
Closesapache/airflow#54248Closesapache/airflow#53884
(cherry picked from commit 3e1638250fb8f58a399ad8c5946dbb77a079f63d)
GitOrigin-RevId: 09560358e062f238e89018dc45dba44fb382b747
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 31, 2026
@kaxil
Fix task log URL generation with various base_url formats (#55699)
8f535a8
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes #54247
Closesapache/airflow#54248Closesapache/airflow#53884
GitOrigin-RevId: 3e1638250fb8f58a399ad8c5946dbb77a079f63d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 2, 2026
@kaxil
Fix task log URL generation with various base_url formats (#55699)
1265141
The `RuntimeTaskInstance.log_url` property
incorrectly concatenated base_url with the path, causing malformed URLs
when base_url didn't end with a slash.
Fixes #54247
Closesapache/airflow#54248Closesapache/airflow#53884
(cherry picked from commit 3e1638250fb8f58a399ad8c5946dbb77a079f63d)
GitOrigin-RevId: 09560358e062f238e89018dc45dba44fb382b747
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthitirkarthitirkarthi left review comments
@amoghrajeshamoghrajeshamoghrajesh left review comments
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
+1 more reviewer
@prdaiprdaiprdai approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jessicaschuelerjessicaschueler

Labels

area:task-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

context["ti"].log_url returns unuseable value

6 participants

@jessicaschueler@kaxil@AlexisNeiraSonos@tirkarthi@amoghrajesh@prdai