Uh oh!
There was an error while loading. Please reload this page.
Fix cron expression display for Day-of-Month and Day-of-Week conflicts - #54644
Conversation
shreyaskj-0710
commented
Aug 22, 2025
Hi @uranusjr , can you please review the code changes. |
shreyaskj-0710
commented
Aug 25, 2025
Hi @pierrejeambrun , @kaxil can you please review the changes |
There was a problem hiding this comment.
At first I'm not in favor of this change. I don't really understand why this is needed. I would keep the standard cron description, if users cannot read cron expressions, they should go check the documentation. (I'm not strongly against it if this helps users)
Can you add relevant tests please.
shreyaskj-0710
commented
Sep 3, 2025
Hi @pierrejeambrun , |
bbovenzi
commented
Sep 15, 2025
I mean if this is a more accurate description then sure. I also see the cron-descriptor has the same bug. Looks like we need to rebase and fix some tests though. |
The existing description is objectively incorrect. It's not just more accurate; the existing implementation is broken and the proposed fix makes it not broken. |
OK I get it now. Current default description is wrong when both are specified. (I tested on other tools and they all do the same mistake). Yes the tooltip needs to be fixed Is that the only known 'bug' in the cron description?
|
RNHTTR
commented
Sep 17, 2025
This is the only bug that I'm aware of. Other descriptions appear accurate. |
pierrejeambrun
commented
Sep 18, 2025
Glad to hear. I think we can move forward then. @shreyaskj-0710 Do you mind rebasing the PR and fixing the CI please. |
shreyaskj-0710
commented
Sep 24, 2025
Hi @pierrejeambrun , Have updated the PR and fixed the CI |
Uh oh!
There was an error while loading. Please reload this page.
…eek conflicts (#54644) * Fix cron expression display for Day-of-Month and Day-of-Week conflicts * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute --------- (cherry picked from commit c6531bb) Co-authored-by: shreyaskj-0710 <shreyas.kj@zemosolabs.com> Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
…eek conflicts (#54644) * Fix cron expression display for Day-of-Month and Day-of-Week conflicts * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute --------- (cherry picked from commit c6531bb) Co-authored-by: shreyaskj-0710 <shreyas.kj@zemosolabs.com> Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
…eek conflicts (#54644) (#56255) * Fix cron expression display for Day-of-Month and Day-of-Week conflicts * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute --------- (cherry picked from commit c6531bb) Co-authored-by: shreyaskj-0710 <shreyas.kj@zemosolabs.com> Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
apache#54644) * Fix cron expression display for Day-of-Month and Day-of-Week conflicts * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute * Add test case for CronMixin description attribute --------- Co-authored-by: Ryan Hatter <25823361+RNHTTR@users.noreply.github.com>
Fixes#54482
Description
📌 Day-of-Month (DOM) and Day-of-Week (DOW) Conflict in Cron
In cron syntax, both Day-of-Month (DOM) and Day-of-Week (DOW) fields are evaluated independently.
If both are specified, the schedule runs when either condition matches (logical OR), not when both are true together.
Example
Cron expression : * * */1 * 5
*/1 → effectively means every day of the month
Together → Every minute (or) Every minute, only on Friday (but since */1 means every day, the Friday part becomes
redundant).
Approach
Each variant is described independently, and the final description combines them using “(or)”, which matches actual cron semantics.
In UI Timetable description will be as follows
