Improve test maintainability for supervisor request handling tests - #54792

Merged
kaxil merged 1 commit into
apache:mainfrom
astronomer:better-handle-request-test
Aug 21, 2025
Merged

Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom
astronomer:better-handle-request-test

Conversation

@kaxil

@kaxilkaxil commented Aug 21, 2025

Copy link
Copy Markdown
Member

Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.

This change makes the test suite more maintainable for developers working on the supervisor communication protocol.

All the existing tests have been ported over.

Tests:

task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

kaxil
kaxil commented Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed the better-handle-request-test branch from 524ad96 to 2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed the better-handle-request-test branch from 2e7d39d to 1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil merged commit 819db98 into apache:mainAug 21, 2025
76 checks passed
@kaxil
kaxil deleted the better-handle-request-test branch August 21, 2025 20:35
@ashbashb mentioned this pull request Aug 21, 2025
Closed
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees

No one assigned

Labels

area:task-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Improve test maintainability for supervisor request handling tests - #54792
Merged
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Aug 21, 2025
Merged
Improve test maintainability for supervisor request handling tests#54792
kaxil merged 1 commit into
apache:mainfrom 
astronomer:better-handle-request-test
Conversation
@kaxil
@kaxilkaxil
commented
Aug 21, 2025

Copy link


Copy Markdown

Member
Refactor large parametrized test from individual parameters to dataclass structure for better readability and maintainability. The test now uses a RequestTestCase dataclass instead of 7 separate parameters, making it much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]

^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
kaxil
kaxil
commented
Aug 21, 2025
View reviewed changes
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
524ad96 to
2e7d39dCompareAugust 21, 2025 19:00
@kaxil
Improve test maintainability for supervisor request handling tests
1160eba
Refactor large parametrized test from individual parameters to dataclass
structure for better readability and maintainability. The test now uses
a `RequestTestCase` dataclass instead of 7 separate parameters, making it
much easier to add new test cases and understand existing ones.
This change makes the test suite more maintainable for developers working
on the supervisor communication protocol.
All the existing tests have been ported over.
Tests:
```
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection] PASSED [ 2%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_password] PASSED [ 4%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_connection_with_alias] PASSED [ 7%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_variable] PASSED [ 9%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_variable] PASSED [ 12%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_variable] PASSED [ 14%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_deferred] PASSED [ 17%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_up_for_reschedule] PASSED [ 19%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom] PASSED [ 21%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_map_index] PASSED [ 24%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_not_found] PASSED [ 26%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_include_prior_dates] PASSED [ 29%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom] PASSED [ 31%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index] PASSED [ 34%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_xcom_with_map_index_and_mapped_length] PASSED [ 36%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[delete_xcom] PASSED [ 39%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[up_for_retry] PASSED [ 41%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[set_rtif] PASSED [ 43%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[succeed_task] PASSED [ 46%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_name] PASSED [ 48%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_by_uri] PASSED [ 51%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri_and_name] PASSED [ 53%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_uri] PASSED [ 56%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_name] PASSED [ 58%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_asset_events_by_asset_alias] PASSED [ 60%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[validate_inlets_and_outlets] PASSED [ 63%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_prev_successful_dagrun] PASSED [ 65%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger] PASSED [ 68%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[dag_run_trigger_already_exists] PASSED [ 70%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dag_run_state] PASSED [ 73%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun] PASSED [ 75%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_previous_dagrun_with_state] PASSED [ 78%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_reschedule_start_date] PASSED [ 80%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_ti_count] PASSED [ 82%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_dr_count] PASSED [ 85%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_task_states] PASSED [ 87%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item] PASSED [ 90%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_item_not_found] PASSED [ 92%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[get_xcom_seq_slice] PASSED [ 95%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[patch_task_instance_to_skipped] PASSED [ 97%]
task-sdk/tests/task_sdk/execution_time/test_supervisor.py::TestHandleRequest::test_handle_requests[create_hitl_detail_payload] PASSED [100%]
```
@kaxil
kaxilforce-pushed
the
better-handle-request-test
branch
from
2e7d39d to
1160ebaCompareAugust 21, 2025 19:41
@kaxil
kaxil
merged commit 819db98
into
apache:mainAug 21, 2025

76 checks passed

@kaxil
kaxil
deleted the

better-handle-request-test

branch
August 21, 2025 20:35
@ashbashb
mentioned this pull request
Aug 21, 2025

Closed

mangal-vairalkar pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
@kaxil@mangal-vairalkar
Improve test maintainability for supervisor request handling tests (a…
541b76a
…pache#54792)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@ashbashbAwaiting requested review from ashbashb is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk