Skip to content

Add Support for GitHub App Installation Authentication in GithubHook - #54812

Merged
Lee-W merged 9 commits into
apache:mainfrom
jeff3071:feat/github_auth
Nov 22, 2025
Merged

Add Support for GitHub App Installation Authentication in GithubHook#54812
Lee-W merged 9 commits into
apache:mainfrom
jeff3071:feat/github_auth

Conversation

@jeff3071

@jeff3071jeff3071 commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

closes: #39457

Summary

This PR add support for GitHub App Installation Authentication in GithubHook.

If access_token is not provided, read key_path, app_id, installation_id, and optional token_permissions from extra field.

Other Change

  • Use airflow.sdk.timezone to replace airflow.utils.timezone.

Related Document

Github app document
Example app installation authentication

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jeff3071
jeff3071 marked this pull request as ready for review August 26, 2025 14:40
Lee-W
Lee-W reviewed Nov 4, 2025
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey sorry for late review. left a few comments. but I think we're close to merge

Comment threadproviders/github/docs/connections/github.rst
Comment threadproviders/github/src/airflow/providers/github/hooks/github.py Outdated
Comment threadproviders/github/src/airflow/providers/github/hooks/github.py Outdated
@eladkaleladkal changed the title Feat/GitHub authAdd Support for GitHub App Installation Authentication in GithubHookNov 4, 2025
@Lee-W
Lee-W self-requested a review November 19, 2025 12:31
@Lee-W

Lee-W commented Nov 19, 2025

Copy link
Copy Markdown
Member

still need some fix on CI failure. will take a look tomorrow

jason810496
jason810496 reviewed Nov 20, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

Comment threadproviders/github/src/airflow/providers/github/hooks/github.py Outdated
Comment threadproviders/github/src/airflow/providers/github/hooks/github.py Outdated
Comment threadproviders/github/src/airflow/providers/github/hooks/github.py
Comment threadproviders/github/docs/connections/github.rst
jason810496
jason810496 reviewed Nov 20, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Please feel free to resolve the addressed comments.

Sorry I should raise the nit in previous review:
How about adding unit test for get_conn method to check the new branch logic?
Thanks!

@jeff3071

jeff3071 commented Nov 21, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks for the update! Please feel free to resolve the addressed comments.

Sorry I should raise the nit in previous review: How about adding unit test for get_conn method to check the new branch logic? Thanks!

Thanks for addressing this!
I add some unit test to check get_conn method.

jason810496
jason810496 approved these changes Nov 21, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Lee-W
Lee-W merged commit 9200ae2 into apache:mainNov 22, 2025
79 checks passed
@jscheffljscheffl mentioned this pull request Nov 27, 2025
Closed
62 tasks
CopilotAI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
@jeff3071
Add Support for GitHub App Installation Authentication in GithubHook (
d938d14
apache#54812)
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
@jeff3071@itayweb
Add Support for GitHub App Installation Authentication in GithubHook (
795335c
apache#54812)
dym-ok added a commit to dym-ok/airflow that referenced this pull request Jan 16, 2026
@dym-ok
Adds a "private_key" alternative extra field to GitHub connection
71d5786
This PR adds support for GitHub App private keys stored directly in
connections (e.g. in AWS Secrets Manager).
`private_key` field is an alternative to `key_path`.
This is a followup for apache#54812.
@dym-okdym-ok mentioned this pull request Jan 16, 2026
Merged
dym-ok added a commit to dym-ok/airflow that referenced this pull request Feb 2, 2026
@dym-ok
Adds a "private_key" alternative extra field to GitHub connection
1af3ba0
This PR adds support for GitHub App private keys stored directly in
connections (e.g. in AWS Secrets Manager).
`private_key` field is an alternative to `key_path`.
This is a followup for apache#54812.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@jason810496jason810496jason810496 approved these changes
@pankajkotipankajkotiAwaiting requested review from pankajkoti

Assignees

No one assigned

Labels

area:providerskind:documentationprovider:github

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Support for GitHub App Installation Authentication in GithubHook

3 participants

@jeff3071@Lee-W@jason810496