Skip to content

Add reusable FilterBar component for date, number, text input - #54895

Merged
bbovenzi merged 15 commits into
apache:mainfrom
RoyLee1224:filterPill
Sep 10, 2025
Merged

Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom
RoyLee1224:filterPill

Conversation

@RoyLee1224

@RoyLee1224RoyLee1224 commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Why

As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.

I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.

What

  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:
    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:
    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.

Screenshots

filterPill.mp4

TO-DO

  • Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@RoyLee1224
RoyLee1224 marked this pull request as draft August 25, 2025 04:31
guan404ming
guan404ming reviewed Aug 25, 2025
View reviewed changes

@guan404mingguan404ming left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming reviewed Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx Outdated
Lee-W
Lee-W reviewed Aug 26, 2025
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good

@RoyLee1224

RoyLee1224 commented Aug 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@guan404ming thanks for super helpful feedback. You're so great at code review !

bbovenzi
bbovenzi reviewed Aug 28, 2025
View reviewed changes

@bbovenzibbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx Outdated
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx Outdated
bbovenzi
bbovenzi reviewed Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx Outdated
guan404ming
guan404ming reviewed Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx Outdated
@RoyLee1224
RoyLee1224 marked this pull request as ready for review September 2, 2025 05:58
@RoyLee1224RoyLee1224 changed the title [WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224

RoyLee1224 commented Sep 2, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

UI Update Screenshots

CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39

bbovenzi
bbovenzi reviewed Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json Outdated
bbovenzi
bbovenzi reviewed Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json Outdated
bbovenzi
bbovenzi reviewed Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx Outdated
bbovenzi
bbovenzi reviewed Sep 2, 2025
View reviewed changes

@bbovenzibbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there

bbovenzi
bbovenzi reviewed Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx Outdated
@RoyLee1224
RoyLee1224 marked this pull request as draft September 8, 2025 21:29
@bbovenzi

bbovenzi commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

TODO:

  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters

filters should be like this:

 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1

@RoyLee1224

RoyLee1224 commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?

@RoyLee1224
RoyLee1224 marked this pull request as ready for review September 9, 2025 17:51
@bbovenzi

bbovenzi commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.

@RoyLee1224

RoyLee1224 commented Sep 9, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@bbovenzi I think we'll need a allow translation change label for deleting filter translations

@bbovenzi

bbovenzi commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

@bbovenzi I think we'll need a allow translation change label for deleting filter translations

That's fine. This is a worthwhile improvement to have

bbovenzi
bbovenzi reviewed Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx Outdated
@bbovenzibbovenzi added the allow translation change This label should be set if we want to bypass translation freeze and change english translations. label Sep 10, 2025
bbovenzi
bbovenzi approved these changes Sep 10, 2025
View reviewed changes

@bbovenzibbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bbovenzi
bbovenzi merged commit 2a1c686 into apache:mainSep 10, 2025
55 checks passed
This was referenced Sep 10, 2025
Merged
Merged
@Lee-WLee-W mentioned this pull request Sep 10, 2025
Merged
@kaxil

kaxil commented Sep 11, 2025

Copy link
Copy Markdown
Member

@bbovenzi Do we want this in 3.1.0?

@kaxil

kaxil commented Sep 11, 2025

Copy link
Copy Markdown
Member

@bbovenzi Do we want this in 3.1.0?

Ok Saw the message on i18n on Slack, cherry-picking it

kaxil pushed a commit to astronomer/airflow that referenced this pull request Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224 deleted the filterPill branch September 11, 2025 13:34
@RoyLee1224RoyLee1224 mentioned this pull request Sep 11, 2025
Closed
5 tasks
@KatalKavya96KatalKavya96 mentioned this pull request Sep 14, 2025
Closed
@RoyLee1224

RoyLee1224 commented Sep 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Follow up PR

  • Add number range filter
  • Add date range filter
  • Add tag filter

suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees

No one assigned

Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add reusable FilterBar component for date, number, text input by RoyLee1224 · Pull Request #54895 · apache/airflow · GitHub
Skip to content
Add reusable FilterBar component for date, number, text input - #54895
Merged
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Sep 10, 2025
Merged
Add reusable FilterBar component for date, number, text input#54895
bbovenzi merged 15 commits into
apache:mainfrom 
RoyLee1224:filterPill
Conversation
@RoyLee1224
@RoyLee1224RoyLee1224
commented
Aug 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Why
As mentioned in #54049 (comment), the filters take up too much screen space. To address this, this PR introduces a new, reusable "filter pill" component design for date, number, text input.
I would appreciate any early feedback on the overall design and direction. All comments and suggestions are welcome.
What
  • Add & Edit: Click + Filter to select a filter type from the dropdown menu. A new filter pill appears and is automatically focused. You can also click on any existing pill to edit its value.
  • Confirm & Cancel: Once you're done typing, you can:

    • Press Enter to confirm the value and apply the filter.
    • Press Esc or click anywhere outside the input area to cancel and exit editing mode.
  • Delete:

    • Click the x icon on any pill to remove that specific filter.
    • Click Reset button to clear all active filters at once.
Screenshots
filterPill.mp4
TO-DO
  •  Working on resolving an issue with the NumberFilter where inputting a minus sign (-) causes UI bug.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@RoyLee1224
RoyLee1224
marked this pull request as draft
August 25, 2025 04:31
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
@guan404mingguan404ming
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really really good to me! The design not only improves UX also enhances extensibility. Still need more iteration and discussion but like it very much. 👍
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/types.ts
guan404ming
guan404ming
reviewed
Aug 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Lee-W
Lee-W
reviewed
Aug 26, 2025
View reviewed changes
@Lee-WLee-W
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation looks good
@RoyLee1224
RoyLee1224
commented
Aug 26, 2025

Copy link


Copy Markdown

ContributorAuthor
@guan404ming thanks for super helpful feedback. You're so great at code review !
bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting! Let's just clean up a few details. Its ok to just change XComFilters in this PR and then we can change others in subsequent PRs
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/TextSearchFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/pages/XCom/XComFilters.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Aug 28, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

guan404ming
guan404ming
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/filters/DateFilter.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 2, 2025 05:58
@RoyLee1224RoyLee1224
changed the title
[WIP] Add reusable FilterBar component for date, number, text inputAdd reusable FilterBar component for date, number, text inputSep 2, 2025
@RoyLee1224
RoyLee1224
commented
Sep 2, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
UI Update Screenshots
CleanShot 2025-09-02 at 02 06 31CleanShot 2025-09-02 at 02 06 39
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/common.json
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/constants/filterConfigs.tsx
Outdated

bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. We're very close, just a few suggestions here and there
bbovenzi
bbovenzi
reviewed
Sep 2, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@RoyLee1224
RoyLee1224
marked this pull request as draft
September 8, 2025 21:29
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
TODO:
  • delete filter placeholder translations
  • delete dagName translations
  • rename date filters
filters should be like this:
 "filters": {
"filter": "Filter",
"logicalDateFrom": "Logical Date From",
"logicalDateTo": "Logical Date To",
"reset": "Reset",
"runAfterFrom": "Run After From",
"runAfterTo": "Run After To"
},

Any update on these todos? Would really like to get this in for 3.1
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I've held off on the translation changes for now. Just wanted to confirm: is the plan to add/modify those after the freeze is lifted?
@RoyLee1224
RoyLee1224
marked this pull request as ready for review
September 9, 2025 17:51
@bbovenzi
bbovenzi
commented
Sep 9, 2025

Copy link


Copy Markdown

Contributor
Let's move forward but we can try to keep the translation surface area to a minimum like just common:filter: "Filter", I think deleting filters is fine too.
@RoyLee1224
RoyLee1224
commented
Sep 9, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
@bbovenzi
bbovenzi
commented
Sep 10, 2025

Copy link


Copy Markdown

Contributor
@bbovenzi I think we'll need a allow translation change label for deleting filter translations
That's fine. This is a worthwhile improvement to have
bbovenzi
bbovenzi
reviewed
Sep 10, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/components/FilterBar/FilterBar.tsx
Outdated

@bbovenzibbovenzi
added
the 
allow translation change
This label should be set if we want to bypass translation freeze and change english translations.
label
Sep 10, 2025
bbovenzi
bbovenzi
approved these changes
Sep 10, 2025
View reviewed changes
@bbovenzibbovenzi
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
@bbovenzi
bbovenzi
merged commit 2a1c686
into
apache:mainSep 10, 2025

55 checks passed


This was referenced Sep 10, 2025
 Merged

 Merged

@Lee-WLee-W
mentioned this pull request
Sep 10, 2025
 Merged

@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
@kaxil
kaxil
commented
Sep 11, 2025

Copy link


Copy Markdown

Member
@bbovenzi Do we want this in 3.1.0?
Ok Saw the message on i18n on Slack, cherry-picking it
kaxil pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
@RoyLee1224@bbovenzi@kaxil
Add reusable FilterBar component for date, number, text input (apache…
73ff74a
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
(cherry picked from commit 2a1c686)
@RoyLee1224
RoyLee1224
deleted the

filterPill

branch
September 11, 2025 13:34
@RoyLee1224RoyLee1224
mentioned this pull request
Sep 11, 2025

Closed

5 tasks
@KatalKavya96KatalKavya96
mentioned this pull request
Sep 14, 2025
 Closed

@RoyLee1224
RoyLee1224
commented
Sep 16, 2025

Copy link


Copy Markdown

ContributorAuthor
Follow up PR
  • Add number range filter
  • Add date range filter
  • Add tag filter
suman-himanshu pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@suman-himanshu
Add reusable FilterBar component for date, number, text input (apache…
3919c6c
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10 pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
@RoyLee1224@bbovenzi@Brunda10
Add reusable FilterBar component for date, number, text input (apache…
529266e
…#54895)
* feat(ui): add reusable FilterBar component for date, number, text input
* fix(ui): improve FilterPill focus and blur handling
* refactor(ui): create useFiltersHandler hook for FilterBar
* refactor(ui):Support negative number input & fix FilterPill DOM nesting
* feat(ui): create centralized filter config
* fix(ui): apply style feedback to FilterBar
* refactor(ui): move getFilterConfig calls into useFiltersHandler & remove placeholder translation fallback
* refactor: simplify DateFilter with dayjs
* fix(ui): Add FilterTypes enum to avoid type casting
* fix(i18n): add missing translation keys
* fix(i18n): move filter translation key to free exemptions
* fix(i18n): Replace dagName translation with dag ID
* fix(i18n): simplify filter translations with fallbacks
* fix: modify reset button translation key
---------
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
@potiukpotiuk
mentioned this pull request
Nov 8, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lee-WLee-WLee-W left review comments
@guan404mingguan404mingguan404ming left review comments
@bbovenzibbovenzibbovenzi approved these changes
@jason810496jason810496Awaiting requested review from jason810496
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@ashbashbAwaiting requested review from ashb
@kaxilkaxilAwaiting requested review from kaxil
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddy
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruin
@jedcunninghamjedcunninghamAwaiting requested review from jedcunningham
@dstandishdstandishAwaiting requested review from dstandish
@eladkaleladkalAwaiting requested review from eladkal
@potiukpotiukAwaiting requested review from potiuk
@gopidesupavangopidesupavanAwaiting requested review from gopidesupavan
@FokkoFokkoAwaiting requested review from Fokko
@mik-lajmik-lajAwaiting requested review from mik-laj
@hussein-awalahussein-awalaAwaiting requested review from hussein-awala
@mobuchowskimobuchowskiAwaiting requested review from mobuchowski
@vincbeckvincbeckAwaiting requested review from vincbeck
@bugraoz93bugraoz93Awaiting requested review from bugraoz93
@josh-felljosh-fellAwaiting requested review from josh-fell
@o-nikolaso-nikolasAwaiting requested review from o-nikolas
@uranusjruranusjrAwaiting requested review from uranusjr
@BasPHBasPHAwaiting requested review from BasPH
@shahar1shahar1Awaiting requested review from shahar1
@romsharon98romsharon98Awaiting requested review from romsharon98
@rawwarrawwarAwaiting requested review from rawwar
@XD-DENGXD-DENGAwaiting requested review from XD-DENG

Assignees


No one assigned


Labels

allow translation changeThis label should be set if we want to bypass translation freeze and change english translations.area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@RoyLee1224@bbovenzi@kaxil@Lee-W@guan404ming