Skip to content

Add pendingActions onto ui/dags - #55041

Merged
bbovenzi merged 8 commits into
apache:mainfrom
astronomer:hitl-on-dags-list
Sep 2, 2025
Merged

Add pendingActions onto ui/dags#55041
bbovenzi merged 8 commits into
apache:mainfrom
astronomer:hitl-on-dags-list

Conversation

@bbovenzi

@bbovenzibbovenzi commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Related: #54961

Add hitl that need reviews as pending_actions on ui/dags. Show "Needs Review" as a badge on the dags list. Allow a user to filter the dags list to only show dags that need review. Dashboard link now redirects to the dags list filtered.

Screenshot 2025-08-29 at 12 56 26 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Aug 28, 2025
@Lee-W
Lee-W self-requested a review August 28, 2025 23:53
@Lee-WLee-W moved this to In progress in AIP-90 - Human in the loopAug 29, 2025
@bbovenzi
bbovenzi marked this pull request as ready for review August 29, 2025 17:00
@bbovenzi

Copy link
Copy Markdown
ContributorAuthor

Need to do some more "Required Actions" -> "Needs Review" renaming but in another PR

@jscheffljscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter looks good in general but ... naming is hard. I am not 100% OK with "Needs Review". Functional and Code is perfect!

Comment threadairflow-core/src/airflow/api_fastapi/common/parameters.py
Comment threadairflow-core/src/airflow/ui/src/pages/DagsList/DagsFilters/StateFilters.tsx Outdated
Comment threadairflow-core/src/airflow/ui/public/i18n/locales/en/hitl.json Outdated
@Lee-WLee-W moved this from In progress to In review in AIP-90 - Human in the loopAug 30, 2025

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, this can be done in follow-up PR.

Would it be better to check whether the pending_actions_select.value is None or not then decide whether to execute the pending_actions_select query?

Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py Outdated
@shahar1

Copy link
Copy Markdown
Contributor

If you plan to merge it before the 3.1 release, please consider my comment in this PR: #55119 (comment)

@Lee-W

Lee-W commented Sep 1, 2025

Copy link
Copy Markdown
Member

If you plan to merge it before the 3.1 release, please consider my comment in this PR: #55119 (comment)

sure :)

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, but looks good. Thanks.

Comment threadairflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_dags.py Outdated
@bbovenzi

Copy link
Copy Markdown
ContributorAuthor

If you plan to merge it before the 3.1 release, please consider my comment in this PR: #55119 (comment)

Thanks for the reminder. I'll try to reduce the i18n surface area of this PR and keep any renaming discussion on a follow up branch.

@bbovenzi
bbovenzi merged commit 06ce1bb into apache:mainSep 2, 2025
107 checks passed
@bbovenzi
bbovenzi deleted the hitl-on-dags-list branch September 2, 2025 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:default

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

@bbovenzi@shahar1@Lee-W@pierrejeambrun@jason810496@jscheffl