Skip to content

fix(api_fastapi): adjust model validator signature of TriggerDAGRunPo… - #56026

Merged
pierrejeambrun merged 1 commit into
apache:mainfrom
dada-engineer:fix/56025-dag-run-post-body-validation
Sep 30, 2025
Merged

fix(api_fastapi): adjust model validator signature of TriggerDAGRunPo…#56026
pierrejeambrun merged 1 commit into
apache:mainfrom
dada-engineer:fix/56025-dag-run-post-body-validation

Conversation

@dada-engineer

@dada-engineerdada-engineer commented Sep 24, 2025•
edited by jason810496
Loading

Copy link
Copy Markdown
Contributor

closes: #56025

The model validator signature of TriggerDAGRunPostBody was defined to match a before validator, it is using a after validator though. This validator type should expect the instaniated model itself not the class and a values dict.

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Sep 24, 2025
pierrejeambrun
pierrejeambrun approved these changes Sep 24, 2025
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

LGTM.

CI need fixing.

@pierrejeambrun

pierrejeambrun commented Sep 24, 2025

Copy link
Copy Markdown
Member

CI need fixing.

That looks unrelated, let me rebase your branch and start again the CI

@pierrejeambrun
pierrejeambrunforce-pushed the fix/56025-dag-run-post-body-validation branch from 8126d10 to 3333306CompareSeptember 24, 2025 08:21
jason810496
jason810496 approved these changes Sep 25, 2025
View reviewed changes

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Just rebased again to fix the CI error.

@jason810496
jason810496force-pushed the fix/56025-dag-run-post-body-validation branch from 3333306 to 16684f5CompareSeptember 25, 2025 04:23
@bugraoz93

bugraoz93 commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Thanks for the PR!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.1.1 milestone Sep 30, 2025
@pierrejeambrun
pierrejeambrun merged commit bfb7ecb into apache:mainSep 30, 2025
205 of 209 checks passed
github-actionsBot pushed a commit that referenced this pull request Sep 30, 2025
@dada-engineerDaniel GellertYour friendly bot
[v3-1-test] fix(api_fastapi): adjust model validator signature of Tri…
98accc1
…ggerDAGRunPostBody (#56025) (#56026)
(cherry picked from commit bfb7ecb)
Co-authored-by: Daniel Gellert <gellertd@protonmail.com>
Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
@github-actions

github-actionsBot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-1-test

StatusBranchResult
✅v3-1-testPR Link

@jason810496jason810496 mentioned this pull request Sep 30, 2025
Closed
2 tasks
pierrejeambrun pushed a commit that referenced this pull request Oct 1, 2025
@dada-engineerDaniel Gellert@pierrejeambrun
[v3-1-test] fix(api_fastapi): adjust model validator signature of Tri…
85caa37
…ggerDAGRunPostBody (#56025) (#56026)
(cherry picked from commit bfb7ecb)
Co-authored-by: Daniel Gellert <gellertd@protonmail.com>
Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request Oct 1, 2025
@github-actions@dada-engineerDaniel Gellert
[v3-1-test] fix(api_fastapi): adjust model validator signature of Tri…
bf2f633
…ggerDAGRunPostBody (#56025) (#56026) (#56256)
(cherry picked from commit bfb7ecb)
Co-authored-by: Daniel Gellert <gellertd@protonmail.com>
Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@dada-engineerDaniel Gellert@dabla
fix(api_fastapi): adjust model validator signature of TriggerDAGRunPo…
f12cf02
…stBody (apache#56025) (apache#56026)
Co-authored-by: Daniel Gellert <dab.dada@gmail.com>
@fredthomsen

fredthomsen commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Is this coming into the 3.0.x line? because without this then manual DAG triggering in 3.0.x is effectively broken correct?

@dada-engineer

dada-engineer commented Oct 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@fredthomsen IMO it is broken yes, and I think it will be part of 3.1.1

@potiuk

potiuk commented Oct 22, 2025

Copy link
Copy Markdown
Member

Yes. We generally practically never fix things in past branch if new release is already out. You should simply upgrade to latest version of airflow released when it is released to fix any bugs.

That's our policy. The only exception is 2.11 that will get security and critical fixes unti April 2026 (also our policy).

@potiukpotiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@jason810496jason810496jason810496 approved these changes
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Milestone

Airflow 3.1.1

Development

Successfully merging this pull request may close these issues.

TriggerDAGRunPostBody model validator issue

6 participants

@dada-engineer@pierrejeambrun@bugraoz93@fredthomsen@potiuk@jason810496